chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java - Issue 2407303005: Let embedder provide select action mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

Issue 2407303005: Let embedder provide select action mode (Closed)

Patch Set: more comments addressed Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java ('k') | content/browser/android/content_view_core_impl.h » ('j') | content/public/android/java/src/org/chromium/content/browser/FloatingWebActionModeCallback.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

index 99b64bc5d6aa2886b4649dfbc3ccb1b1b9d581d0..e4f7567ab773a4ed6c464b2458e87a2e1189b491 100644

--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java

@@ -23,6 +23,7 @@ import org.chromium.content.browser.ContentVideoViewEmbedder;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.ContentViewRenderView;

+import org.chromium.content.browser.WebActionMode;

import org.chromium.content_public.browser.LoadUrlParams;

import org.chromium.content_public.browser.NavigationController;

import org.chromium.content_public.browser.WebContents;

@@ -136,7 +137,7 @@ public class CastWindowAndroid extends LinearLayout {

mContentViewCore = new ContentViewCore(context, productVersion);

ContentView view = ContentView.createContentView(context, mContentViewCore);

mContentViewCore.initialize(ViewAndroidDelegate.createBasicDelegate(view), view,

- webContents, mWindow);

+ webContents, mWindow, WebActionMode.EMPTY_CALLBACK);

mWebContents = mContentViewCore.getWebContents();

mNavigationController = mWebContents.getNavigationController();

mRenderProcessId = renderProcessId;