chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java - Issue 2407303005: Let embedder provide select action mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

Issue 2407303005: Let embedder provide select action mode (Closed)

Patch Set: more comments addressed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java ('k') | chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java » ('j') | content/public/android/java/src/org/chromium/content/browser/FloatingWebActionModeCallback.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

index dec61d0eef25c185c032e965cf149e4ae9e6c642..76d33aa8835b1c3023c700cc2663255870f57828 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

@@ -15,6 +15,7 @@ import org.chromium.chrome.browser.WebContentsFactory;

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewCore;

+import org.chromium.content.browser.WebActionMode;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

import org.chromium.content.browser.test.util.DOMUtils;

@@ -91,7 +92,7 @@ public class SelectPopupOtherContentViewTest extends ChromeActivityTestCaseBase<

ContentViewCore contentViewCore = new ContentViewCore(getActivity(), "");

ContentView cv = ContentView.createContentView(getActivity(), contentViewCore);

contentViewCore.initialize(ViewAndroidDelegate.createBasicDelegate(cv), cv,

- webContents, windowAndroid);

+ webContents, windowAndroid, WebActionMode.EMPTY_CALLBACK);

contentViewCore.destroy();

}

});