Replace Java based analyzer with Dart based analyzer when building SDK

tools/create_sdk.py

Index: tools/create_sdk.py
diff --git a/tools/create_sdk.py b/tools/create_sdk.py
index c8f79edbdc7a00315dcc5f96662b581f9668d898..049827ca0ae33fb4eb0c0217b675096a31ab6c57 100755
--- a/tools/create_sdk.py
+++ b/tools/create_sdk.py
@@ -21,6 +21,7 @@
 # ......pub
 # ......snapshots/
 # ........dart2js.dart.snapshot
+# ........dartanalyzer.dart.snapshot
 # ........dartfmt.dart.snapshot
 # ........pub.dart.snapshot
 # ........utils_wrapper.dart.snapshot
@@ -44,9 +45,6 @@
 # ......mirrors/
 # ......typed_data/
 # ....util/
-# ......dartanalyzer/
-# ........dartanalyzer.jar
-# ........(third-party libraries for dart_analyzer)
 # ......(more will come here)
 
 
@@ -114,7 +112,7 @@ def CopyDartScripts(home, sdk_root):
 
 
 def CopySnapshots(snapshots, sdk_root):
-  for snapshot in ['dart2js', 'dartfmt', 'utils_wrapper', 'pub']:
+  for snapshot in ['dart2js', 'dartanalyzer', 'dartfmt', 'utils_wrapper', 'pub']:

[ahe, 2014/04/22 09:38:13]

Long line.

[danrubel, 2014/04/22 18:37:54]

Done.

     snapshot += '.dart.snapshot'
     copyfile(join(snapshots, snapshot),
              join(sdk_root, 'bin', 'snapshots', snapshot))
@@ -220,15 +218,11 @@ def Main(argv):
   UTIL = join(SDK_tmp, 'util')
   os.makedirs(UTIL)
 
-  # Create and copy dartanalyzer into 'util'
-  DARTANALYZER_SRC = join(HOME, build_dir, 'dartanalyzer')
-  DARTANALYZER_DEST = join(UTIL, 'dartanalyzer')
-  os.makedirs(DARTANALYZER_DEST)
-
-  jarFiles = glob.glob(join(DARTANALYZER_SRC, '*.jar'))
-
-  for jarFile in jarFiles:
-    copyfile(jarFile, join(DARTANALYZER_DEST, os.path.basename(jarFile)))
+  # Create and copy dartanalyzer into 'lib/_internal/dartanalyzer'
+  DARTANALYZER = join(SDK_tmp, 'lib', '_internal', 'dartanalyzer')

[ahe, 2014/04/22 09:38:13]

Why is this needed?

[danrubel, 2014/04/22 18:37:54]

Good point. We run the snapshot so we don't need it for running the analyzer. I
was assuming that the end user would like to see the source, but maybe that's
not a good reason. I'll remove it.

+  copytree(join(HOME, 'pkg', 'analyzer'),
+           join(DARTANALYZER),
+           ignore=ignore_patterns('.svn'))
 
   RESOURCE = join(SDK_tmp, 'lib', '_internal', 'pub', 'asset')
   os.makedirs(os.path.dirname(RESOURCE))