Replace Java based analyzer with Dart based analyzer when building SDK

tools/create_sdk.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 # A script which will be invoked from gyp to create an SDK.
 #
 # Usage: create_sdk.py sdk_directory
 #
 # The SDK will be used either from the command-line or from the editor.
 # Top structure is
 #
 # ..dart-sdk/
 # ....bin/
 # ......dart or dart.exe (executable)
 # ......dart.lib (import library for VM native extensions on Windows)
 # ......dartfmt
 # ......dart2js
 # ......dartanalyzer
 # ......pub
 # ......snapshots/
 # ........dart2js.dart.snapshot
+# ........dartanalyzer.dart.snapshot
 # ........dartfmt.dart.snapshot
 # ........pub.dart.snapshot
 # ........utils_wrapper.dart.snapshot
 # ....include/
 # ......dart_api.h
 # ......dart_debugger_api.h
 # ......dart_mirrors_api.h
 # ......dart_native_api.h
 # ....lib/
 # ......_internal/
 # ......async/
 # ......collection/
 # ......convert/
 # ......core/
 # ......html/
 # ......internal/
 # ......io/
 # ......isolate/
 # ......js/
 # ......math/
 # ......mirrors/
 # ......typed_data/
 # ....util/
-# ......dartanalyzer/
-# ........dartanalyzer.jar
-# ........(third-party libraries for dart_analyzer)
 # ......(more will come here)
 
 
 import glob
 import optparse
 import os
 import re
 import sys
 import subprocess
 import tempfile
@@ skipping 47 matching lines @@
   Copy(src, dest)
 
 
 def CopyDartScripts(home, sdk_root):
   for executable in ['dart2js', 'dartanalyzer', 'dartfmt', 'docgen', 'pub']:
     CopyShellScript(os.path.join(home, 'sdk', 'bin', executable),
                     os.path.join(sdk_root, 'bin'))
 
 
 def CopySnapshots(snapshots, sdk_root):
-  for snapshot in ['dart2js', 'dartfmt', 'utils_wrapper', 'pub']:
+  for snapshot in ['dart2js', 'dartanalyzer', 'dartfmt', 'utils_wrapper', 'pub']:

[ahe, 2014/04/22 09:38:13]

Long line.

[danrubel, 2014/04/22 18:37:54]

Done.

     snapshot += '.dart.snapshot'
     copyfile(join(snapshots, snapshot),
              join(sdk_root, 'bin', 'snapshots', snapshot))
 
 
 def Main(argv):
   # Pull in all of the gypi files which will be munged into the sdk.
   HOME = dirname(dirname(realpath(__file__)))
 
   (options, args) = GetOptions()
@@ skipping 85 matching lines @@
                                     '.gitignore'))
 
   # Copy lib/_internal/libraries.dart.
   copyfile(join(HOME, 'sdk', 'lib', '_internal', 'libraries.dart'),
            join(LIB, '_internal', 'libraries.dart'))
 
   # Create and copy tools.
   UTIL = join(SDK_tmp, 'util')
   os.makedirs(UTIL)
 
-  # Create and copy dartanalyzer into 'util'
-  DARTANALYZER_SRC = join(HOME, build_dir, 'dartanalyzer')
-  DARTANALYZER_DEST = join(UTIL, 'dartanalyzer')
-  os.makedirs(DARTANALYZER_DEST)
-
-  jarFiles = glob.glob(join(DARTANALYZER_SRC, '*.jar'))
-
-  for jarFile in jarFiles:
-    copyfile(jarFile, join(DARTANALYZER_DEST, os.path.basename(jarFile)))
+  # Create and copy dartanalyzer into 'lib/_internal/dartanalyzer'
+  DARTANALYZER = join(SDK_tmp, 'lib', '_internal', 'dartanalyzer')

[ahe, 2014/04/22 09:38:13]

Why is this needed?

[danrubel, 2014/04/22 18:37:54]

Good point. We run the snapshot so we don't need it for running the analyzer. I
was assuming that the end user would like to see the source, but maybe that's
not a good reason. I'll remove it.

+  copytree(join(HOME, 'pkg', 'analyzer'),
+           join(DARTANALYZER),
+           ignore=ignore_patterns('.svn'))
 
   RESOURCE = join(SDK_tmp, 'lib', '_internal', 'pub', 'asset')
   os.makedirs(os.path.dirname(RESOURCE))
   copytree(join(HOME, 'sdk', 'lib', '_internal', 'pub', 'asset'),
            join(RESOURCE),
            ignore=ignore_patterns('.svn'))
 
   # Copy in 7zip for Windows.
   if HOST_OS == 'win32':
     copytree(join(HOME, 'third_party', '7zip'),
@@ skipping 17 matching lines @@
     with open(os.path.join(SDK_tmp, 'revision'), 'w') as f:
       f.write(revision + '\n')
       f.close()
 
   Copy(join(HOME, 'README.dart-sdk'), join(SDK_tmp, 'README'))
 
   move(SDK_tmp, SDK)
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))