Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 24072006: Return correct window when user is logged in but before session is started. (Closed)

Created:
7 years, 3 months ago by Tim Song
Modified:
7 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Return correct window when user is logged in but before session is started. The network configuration dialog for secure networks is not displaying correctly during the kiosk splash screen, because a kiosk user is logged in. Update LoginState to track the session started status. BUG=269182 TEST=manually on device

Patch Set 1 #

Patch Set 2 : fix unit test compile error #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M chrome/browser/chromeos/login/user_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 chunk +1 line, -0 lines 1 comment Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/login/login_state.h View 4 chunks +10 lines, -0 lines 0 comments Download
M chromeos/login/login_state.cc View 2 chunks +11 lines, -1 line 0 comments Download
M chromeos/login/login_state_unittest.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Tim Song
This patch adds session awareness to LoginState and use it to determine the ash::user::LoginStatus. Please ...
7 years, 3 months ago (2013-09-13 02:15:52 UTC) #1
stevenjb
https://codereview.chromium.org/24072006/diff/9001/chrome/browser/chromeos/login/user_manager_impl.cc File chrome/browser/chromeos/login/user_manager_impl.cc (right): https://codereview.chromium.org/24072006/diff/9001/chrome/browser/chromeos/login/user_manager_impl.cc#newcode1731 chrome/browser/chromeos/login/user_manager_impl.cc:1731: LoginState::Get()->SetSessionStarted(session_started_); This is confusing to me. Do we really ...
7 years, 3 months ago (2013-09-13 18:22:34 UTC) #2
Tim Song
7 years, 3 months ago (2013-09-13 18:52:49 UTC) #3
Hmm... it looks like we can already distinguish between "logged in" and "session
started" with SessionStateDelegate::IsActiveUserSessionStarted(), so I agree we
shouldn't add additional complexity to LoginState.

I'll close this review and go with another approach. Thank you for the review!

Powered by Google App Engine
This is Rietveld 408576698