Return correct window when user is logged in but before session is started.

chrome/browser/chromeos/login/user_manager_impl.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/user_manager_impl.h"
 
 #include <cstddef>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 1710 matching lines @@
   else if (active_user_->GetType() == User::USER_TYPE_PUBLIC_ACCOUNT)
     login_user_type = LoginState::LOGGED_IN_USER_PUBLIC_ACCOUNT;
   else if (active_user_->GetType() == User::USER_TYPE_LOCALLY_MANAGED)
     login_user_type = LoginState::LOGGED_IN_USER_LOCALLY_MANAGED;
   else if (active_user_->GetType() == User::USER_TYPE_KIOSK_APP)
     login_user_type = LoginState::LOGGED_IN_USER_KIOSK_APP;
   else
     login_user_type = LoginState::LOGGED_IN_USER_REGULAR;
 
   LoginState::Get()->SetLoggedInState(logged_in_state, login_user_type);
+  LoginState::Get()->SetSessionStarted(session_started_);

[stevenjb, 2013/09/13 18:22:34]

This is confusing to me. Do we really need to introduce a separate
'SessionStarted' property to LoginState? Couldn't we just set logged_in_state =
LOGGED_IN_NONE if session_started_ is false?

If there is code that uses LoginState that needs to differentiate between
LOGGED_IN_ACTIVE and LOGGED_IN_SESSION_STARTED, we should add that state instead
of a separate accessor. The intention was to keep LoginState relatively
simple...

 }
 
 void UserManagerImpl::SetLRUUser(User* user) {
   UserList::iterator it = std::find(lru_logged_in_users_.begin(),
                                     lru_logged_in_users_.end(),
                                     user);
   if (it != lru_logged_in_users_.end())
     lru_logged_in_users_.erase(it);
   lru_logged_in_users_.insert(lru_logged_in_users_.begin(), user);
 }
@@ skipping 78 matching lines @@
         base::TimeTicks::Now() - manager_creation_time_;
     if (!last_email.empty() && email != last_email &&
         time_to_login.InSeconds() <= kLogoutToLoginDelayMaxSec) {
       UMA_HISTOGRAM_CUSTOM_COUNTS("UserManager.LogoutToLoginDelay",
           time_to_login.InSeconds(), 0, kLogoutToLoginDelayMaxSec, 50);
     }
   }
 }
 
 }  // namespace chromeos