Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2407163004: [Sync] Move some directory-related things from core/ to syncable/. (Closed)

Created:
4 years, 2 months ago by maxbogue
Modified:
4 years, 2 months ago
Reviewers:
pavely
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Move some directory-related things from core/ to syncable/. Everything is being moved out of core to better homes. Things moved: syncable/ base_node base_transaction change_record change_reorder_buffer delete_journal read_node read_transaction test_user_share user_share write_node write_transaction My knowledge of the role each of these plays is not perfect, so let me know if something should not have been moved. BUG=631271 Committed: https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f Cr-Commit-Position: refs/heads/master@{#424743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -2900 lines) Patch
M chrome/browser/sync/profile_sync_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/enable_disable_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_sync/abstract_profile_sync_service_test.h View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/abstract_profile_sync_service_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.h View 2 chunks +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_autofill_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/browser_sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/browser_sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/BUILD.gn View 11 chunks +23 lines, -23 lines 0 comments Download
D components/sync/core/base_node.h View 1 chunk +0 lines, -243 lines 0 comments Download
D components/sync/core/base_node.cc View 1 chunk +0 lines, -285 lines 0 comments Download
D components/sync/core/base_transaction.h View 1 chunk +0 lines, -61 lines 0 comments Download
D components/sync/core/base_transaction.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D components/sync/core/change_record.h View 1 chunk +0 lines, -69 lines 0 comments Download
D components/sync/core/change_record.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D components/sync/core/change_record_unittest.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D components/sync/core/delete_journal.h View 1 chunk +0 lines, -48 lines 0 comments Download
D components/sync/core/delete_journal.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D components/sync/core/read_node.h View 1 chunk +0 lines, -78 lines 0 comments Download
D components/sync/core/read_node.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D components/sync/core/read_transaction.h View 1 chunk +0 lines, -72 lines 0 comments Download
D components/sync/core/read_transaction.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M components/sync/core/sync_manager.h View 2 chunks +1 line, -1 line 0 comments Download
M components/sync/core/test/fake_sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download
D components/sync/core/test/test_user_share.h View 1 chunk +0 lines, -93 lines 0 comments Download
D components/sync/core/user_share.h View 1 chunk +0 lines, -38 lines 0 comments Download
D components/sync/core/user_share.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D components/sync/core/write_node.h View 1 chunk +0 lines, -182 lines 0 comments Download
D components/sync/core/write_node.cc View 1 chunk +0 lines, -478 lines 0 comments Download
D components/sync/core/write_transaction.h View 1 chunk +0 lines, -82 lines 0 comments Download
D components/sync/core/write_transaction.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D components/sync/core_impl/change_reorder_buffer.h View 1 chunk +0 lines, -94 lines 0 comments Download
D components/sync/core_impl/change_reorder_buffer.cc View 1 chunk +0 lines, -221 lines 0 comments Download
M components/sync/core_impl/js_sync_manager_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core_impl/sync_encryption_handler_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/sync/core_impl/sync_encryption_handler_impl_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/sync/core_impl/sync_manager_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/core_impl/sync_manager_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/sync/core_impl/sync_manager_impl_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/sync/core_impl/test/sync_manager_for_profile_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D components/sync/core_impl/test/test_user_share.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M components/sync/driver/backend_migrator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/backend_migrator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/driver/change_processor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/driver/data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/directory_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/fake_sync_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/driver/generic_change_processor.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/shared_change_processor_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/sync/model/sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/DEPS View 1 chunk +3 lines, -1 line 0 comments Download
A + components/sync/syncable/base_node.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/syncable/base_node.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sync/syncable/base_transaction.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/syncable/base_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/syncable/change_record.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/syncable/change_record.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/sync/syncable/change_record_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/syncable/change_reorder_buffer.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/syncable/change_reorder_buffer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/sync/syncable/delete_journal.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/syncable/delete_journal.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sync/syncable/read_node.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/syncable/read_node.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/sync/syncable/read_transaction.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/syncable/read_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/syncable/test_user_share.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/syncable/test_user_share.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/syncable/user_share.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/syncable/user_share.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/syncable/write_node.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/syncable/write_node.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/syncable/write_transaction.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + components/sync/syncable/write_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/tools/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/tools/sync_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
maxbogue
Pavel, PTAL!
4 years, 2 months ago (2016-10-11 17:38:29 UTC) #6
pavely
lgtm
4 years, 2 months ago (2016-10-12 04:45:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407163004/1
4 years, 2 months ago (2016-10-12 15:09:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 15:33:10 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 15:35:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7efba4aa0524c9e5086005bd98d295bdc57723f
Cr-Commit-Position: refs/heads/master@{#424743}

Powered by Google App Engine
This is Rietveld 408576698