Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: components/sync/core_impl/change_reorder_buffer.h

Issue 2407163004: [Sync] Move some directory-related things from core/ to syncable/. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/core/write_transaction.cc ('k') | components/sync/core_impl/change_reorder_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/core_impl/change_reorder_buffer.h
diff --git a/components/sync/core_impl/change_reorder_buffer.h b/components/sync/core_impl/change_reorder_buffer.h
deleted file mode 100644
index e7db07948ca9f0a27c8e115c2fc6ce14fb166604..0000000000000000000000000000000000000000
--- a/components/sync/core_impl/change_reorder_buffer.h
+++ /dev/null
@@ -1,94 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-//
-// Defines ChangeReorderBuffer, which can be used to sort a list of item
-// actions to achieve the ordering constraint required by the SyncObserver
-// interface of the SyncAPI.
-
-#ifndef COMPONENTS_SYNC_CORE_IMPL_CHANGE_REORDER_BUFFER_H_
-#define COMPONENTS_SYNC_CORE_IMPL_CHANGE_REORDER_BUFFER_H_
-
-#include <stdint.h>
-
-#include <map>
-#include <vector>
-
-#include "base/compiler_specific.h"
-#include "base/macros.h"
-#include "base/memory/linked_ptr.h"
-#include "components/sync/core/change_record.h"
-#include "components/sync/protocol/sync.pb.h"
-
-namespace syncer {
-
-class BaseTransaction;
-
-// ChangeReorderBuffer is a utility type which accepts an unordered set
-// of changes (via its Push methods), and yields an ImmutableChangeRecordList
-// (via the GetAllChangesInTreeOrder method) that are in the order that
-// the SyncObserver expects them to be. A buffer is initially empty.
-//
-// The ordering produced by ChangeReorderBuffer is as follows:
-// (a) All Deleted items appear first.
-// (b) For Updated and/or Added items, parents appear before their children.
-//
-// The sibling order is not necessarily preserved.
-class ChangeReorderBuffer {
- public:
- ChangeReorderBuffer();
- ~ChangeReorderBuffer();
-
- // Insert an item, identified by the metahandle |id|, into the reorder buffer.
- // This item will appear in the output list as an ACTION_ADD ChangeRecord.
- void PushAddedItem(int64_t id);
-
- // Insert an item, identified by the metahandle |id|, into the reorder buffer.
- // This item will appear in the output list as an ACTION_DELETE ChangeRecord.
- void PushDeletedItem(int64_t id);
-
- // Insert an item, identified by the metahandle |id|, into the reorder buffer.
- // This item will appear in the output list as an ACTION_UPDATE ChangeRecord.
- void PushUpdatedItem(int64_t id);
-
- void SetExtraDataForId(int64_t id, ExtraPasswordChangeRecordData* extra);
-
- void SetSpecificsForId(int64_t id, const sync_pb::EntitySpecifics& specifics);
-
- // Reset the buffer, forgetting any pushed items, so that it can be used again
- // to reorder a new set of changes.
- void Clear();
-
- bool IsEmpty() const;
-
- // Output a reordered list of changes to |changes| using the items
- // that were pushed into the reorder buffer. |sync_trans| is used to
- // determine the ordering. Returns true if successful, or false if
- // an error was encountered.
- bool GetAllChangesInTreeOrder(const BaseTransaction* sync_trans,
- ImmutableChangeRecordList* changes)
- WARN_UNUSED_RESULT;
-
- private:
- class Traversal;
- typedef std::map<int64_t, ChangeRecord::Action> OperationMap;
- typedef std::map<int64_t, sync_pb::EntitySpecifics> SpecificsMap;
- typedef std::map<int64_t, linked_ptr<ExtraPasswordChangeRecordData>>
- ExtraDataMap;
-
- // Stores the items that have been pushed into the buffer, and the type of
- // operation that was associated with them.
- OperationMap operations_;
-
- // Stores entity-specific ChangeRecord data per-ID.
- SpecificsMap specifics_;
-
- // Stores type-specific extra data per-ID.
- ExtraDataMap extra_data_;
-
- DISALLOW_COPY_AND_ASSIGN(ChangeReorderBuffer);
-};
-
-} // namespace syncer
-
-#endif // COMPONENTS_SYNC_CORE_IMPL_CHANGE_REORDER_BUFFER_H_
« no previous file with comments | « components/sync/core/write_transaction.cc ('k') | components/sync/core_impl/change_reorder_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698