Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2406973003: Revert of [modules] Store Module metadata in per-Context EmbedderData (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [modules] Store Module metadata in per-Context EmbedderData (patchset #7 id:120001 of https://codereview.chromium.org/2393303002/ ) Reason for revert: Fails under LeakSanitizer on auto-roll fyi bot: https://build.chromium.org/p/client.v8.fyi/builders/Auto-roll%20-%20release%20process/builds/49447 Original issue's description: > [modules] Store Module metadata in per-Context EmbedderData > > Unifies the approaches used for storing the specifier -> module mapping > and the module -> directory mapping, using std::unordered_maps for both > and storing them per-Context. > > This requires adding a method to the v8::Module API to get a hash code > for a Module, but allows slimming down the API in return: gone are > SetEmbedderData/GetEmbedderData, along with the fourth argument > to ResolveModuleCallback. > > Besides a simpler API, this allows d8 to get closer to the HTML loader, > which requires each Realm to have a persistent module map (though this > capability is not yet exercised by any tests). > > BUG=v8:1569 > > Committed: https://crrev.com/9cf8fce74cf6e7afd6aea3f3545f6bb61572f277 > Cr-Commit-Position: refs/heads/master@{#40133} TBR=jochen@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Committed: https://crrev.com/127798897f1fc17c2225d04d32ad90d2a088a66e Cr-Commit-Position: refs/heads/master@{#40145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -104 lines) Patch
M include/v8.h View 1 chunk +7 lines, -7 lines 0 comments Download
M src/api.cc View 1 chunk +13 lines, -4 lines 0 comments Download
M src/d8.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/d8.cc View 11 chunks +35 lines, -84 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/objects.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-modules.cc View 3 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
adamk
Created Revert of [modules] Store Module metadata in per-Context EmbedderData
4 years, 2 months ago (2016-10-11 00:24:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406973003/1
4 years, 2 months ago (2016-10-11 00:24:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 00:25:00 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 00:25:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/127798897f1fc17c2225d04d32ad90d2a088a66e
Cr-Commit-Position: refs/heads/master@{#40145}

Powered by Google App Engine
This is Rietveld 408576698