Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: include/v8.h

Issue 2406973003: Revert of [modules] Store Module metadata in per-Context EmbedderData (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 1ab93b53fe1808d829c205e5681eedab5eae982a..79ef0a03ea66d270d20ad0b2489ad42f0d2b9e57 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1106,22 +1106,22 @@
*/
Local<String> GetModuleRequest(int i) const;
- /**
- * Returns the identity hash for this object.
- */
- int GetIdentityHash() const;
+ void SetEmbedderData(Local<Value> data);
+ Local<Value> GetEmbedderData() const;
typedef MaybeLocal<Module> (*ResolveCallback)(Local<Context> context,
Local<String> specifier,
- Local<Module> referrer);
+ Local<Module> referrer,
+ Local<Value> data);
/**
* ModuleDeclarationInstantiation
*
* Returns false if an exception occurred during instantiation.
*/
- V8_WARN_UNUSED_RESULT bool Instantiate(Local<Context> context,
- ResolveCallback callback);
+ V8_WARN_UNUSED_RESULT bool Instantiate(
+ Local<Context> context, ResolveCallback callback,
+ Local<Value> callback_data = Local<Value>());
/**
* ModuleEvaluation
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698