Issue 2406773002: Fix the build error caused by 2524a5f430bcc8cbc1e8d0c47c5047ba696c7f04

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2406773002: Fix the build error caused by 2524a5f430bcc8cbc1e8d0c47c5047ba696c7f04 (Closed)

Created:
4 years, 2 months ago by leonhsl(Using Gerrit)

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix the build error caused by 2524a5f430bcc8cbc1e8d0c47c5047ba696c7f04 2524a5f430bcc8cbc1e8d0c47c5047ba696c7f04 is a cherry-pick commit introduced by https://codereview.chromium.org/2400393003. It is accessing |binding_| member of {AutofillAgent,PasswordAutofillAgent,PasswordGenerationAgent}. However, on M54 branch, {PasswordAutofillAgent,PasswordGenerationAgent} have no |binding_| member yet, they are introduced after M54 branched out... BUG=641156 TBR=vabr@chromium.org

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	components/autofill/content/renderer/password_autofill_agent.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	components/autofill/content/renderer/password_generation_agent.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

leonhsl(Using Gerrit)

4 years, 2 months ago (2016-10-13 07:35:37 UTC) #2

Close this CL because it has been actually landed as
https://chromium.googlesource.com/chromium/src/+/ce5066548c74c635d3c0477b1a42...
.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages