Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2406763002: In test code, allow any 100% data pack to provide fallbacks. (Closed)

Created:
4 years, 2 months ago by tapted
Modified:
4 years, 1 month ago
Reviewers:
oshima, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In test code, allow any 100% data pack to provide fallbacks. A test is allowed to request a 200% resource and fallback to a 100% resource. Currently only the last-added 100% data pack provides fallbacks, which may only be a small supplement. Instead, scan through all 100% data packs. But only when InitSharedInstanceWithPakPath() has invoked ResourceBundle::LoadTestResources(). BUG=636995 Committed: https://crrev.com/16fe440227ce9e085117faa4c4b7af197de88602 Cr-Commit-Position: refs/heads/master@{#427272}

Patch Set 1 #

Total comments: 2

Patch Set 2 : separate loop #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M ui/base/resource/resource_bundle.h View 1 1 chunk +1 line, -1 line 1 comment Download
M ui/base/resource/resource_bundle.cc View 1 1 chunk +13 lines, -14 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
tapted
Hi oshima, please take a look
4 years, 2 months ago (2016-10-10 03:15:20 UTC) #7
oshima
https://codereview.chromium.org/2406763002/diff/1/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): https://codereview.chromium.org/2406763002/diff/1/ui/base/resource/resource_bundle.cc#newcode835 ui/base/resource/resource_bundle.cc:835: // may provide test fallbacks. if this is for ...
4 years, 2 months ago (2016-10-12 04:22:25 UTC) #8
tapted
oshima, PTAL. Thanks! https://chromiumcodereview.appspot.com/2406763002/diff/1/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): https://chromiumcodereview.appspot.com/2406763002/diff/1/ui/base/resource/resource_bundle.cc#newcode835 ui/base/resource/resource_bundle.cc:835: // may provide test fallbacks. On ...
4 years, 2 months ago (2016-10-20 05:01:13 UTC) #15
oshima
lgtm https://codereview.chromium.org/2406763002/diff/40001/ui/base/resource/resource_bundle.h File ui/base/resource/resource_bundle.h (right): https://codereview.chromium.org/2406763002/diff/40001/ui/base/resource/resource_bundle.h#newcode358 ui/base/resource/resource_bundle.h:358: // |scale_factor| will be set to SCALE_FACTOR_NONE. Thank ...
4 years, 1 month ago (2016-10-24 18:07:09 UTC) #16
oshima
lgtm
4 years, 1 month ago (2016-10-24 18:07:10 UTC) #17
tapted
+sky for /ui OWNERS - Thanks!
4 years, 1 month ago (2016-10-24 22:02:20 UTC) #19
sky
LGTM
4 years, 1 month ago (2016-10-24 22:53:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406763002/40001
4 years, 1 month ago (2016-10-25 03:02:15 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-25 04:02:55 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 04:04:26 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16fe440227ce9e085117faa4c4b7af197de88602
Cr-Commit-Position: refs/heads/master@{#427272}

Powered by Google App Engine
This is Rietveld 408576698