Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2406703002: tracing: remove sampling state profiler (Closed)

Created:
4 years, 2 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, oilpan-reviews, Mads Ager (chromium), blink-reviews-dom_chromium.org, wfh+watch_chromium.org, sof, jam, blink-reviews, dglazkov+blink, darin-cc_chromium.org, agrieve+watch_chromium.org, tracing+reviews_chromium.org, blink-reviews-bindings_chromium.org, eae+blinkwatch, kouhei+heap_chromium.org, tfarina, rwlbuis, alph
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing: remove sampling state profiler As per discussion in [1] the tracing sampling state profiler is not used anymore. The coverage of the TRACE_EVENT_SCOPED_SAMPLING_STATE macros became poor over time and new alternatives came out (e.g., V8 sampling profiler). The overall is sensible but should be re-approached in a more sustainable way. More specifically, the new trace event filters could be leveraged to build a sampling profiler on top of the existing TRACE_EVENT macros. [1] https://groups.google.com/a/chromium.org/d/msg/tracing/E3K6qF1YMI8/wapmBei2AQAJ BUG= Committed: https://crrev.com/7bc681e5c39bda0926e77961273916dc90530558 Cr-Commit-Position: refs/heads/master@{#424212}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -488 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M base/trace_event/common/trace_event_common.h View 1 chunk +0 lines, -10 lines 0 comments Download
M base/trace_event/trace_config.h View 4 chunks +5 lines, -9 lines 0 comments Download
M base/trace_event/trace_config.cc View 11 chunks +0 lines, -14 lines 0 comments Download
M base/trace_event/trace_config_memory_test_util.h View 4 chunks +0 lines, -4 lines 0 comments Download
M base/trace_event/trace_config_unittest.cc View 27 chunks +6 lines, -54 lines 0 comments Download
M base/trace_event/trace_event.h View 3 chunks +0 lines, -72 lines 0 comments Download
M base/trace_event/trace_event_unittest.cc View 2 chunks +3 lines, -73 lines 0 comments Download
M base/trace_event/trace_log.h View 4 chunks +0 lines, -8 lines 0 comments Download
M base/trace_event/trace_log.cc View 6 chunks +3 lines, -42 lines 0 comments Download
M base/trace_event/trace_log_constants.cc View 1 chunk +1 line, -2 lines 0 comments Download
D base/trace_event/trace_sampling_thread.h View 1 chunk +0 lines, -54 lines 0 comments Download
D base/trace_event/trace_sampling_thread.cc View 1 chunk +0 lines, -107 lines 0 comments Download
M components/tracing/browser/trace_config_file_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/tracing_handler_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/webrtc/webrtc_getusermedia_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp View 10 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/Timer.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 34 (21 generated)
Primiano Tucci (use gerrit)
Allright, draining my flight queue
4 years, 2 months ago (2016-10-09 21:49:17 UTC) #15
haraken
LGTM
4 years, 2 months ago (2016-10-10 01:46:27 UTC) #16
Primiano Tucci (use gerrit)
+alph FYI. I am pretty sure this should not interfere with your v8 profiler work, ...
4 years, 2 months ago (2016-10-10 16:41:21 UTC) #17
oystein (OOO til 10th of July)
Another enthusiastic lgtm!
4 years, 2 months ago (2016-10-10 17:00:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406703002/40001
4 years, 2 months ago (2016-10-10 18:02:42 UTC) #20
Primiano Tucci (use gerrit)
+pfeldman to stamp remaining diffs in content/ outside of content/tracing +brettw for -1 line in ...
4 years, 2 months ago (2016-10-10 18:07:35 UTC) #22
Lei Zhang
On 2016/10/10 18:07:35, Primiano Tucci - slow til 10th wrote: > +thestig for -2 lines ...
4 years, 2 months ago (2016-10-10 18:09:50 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/277547)
4 years, 2 months ago (2016-10-10 18:12:24 UTC) #25
brettw
bootstrap lgtm (I'll fix owners for that file)
4 years, 2 months ago (2016-10-10 18:20:21 UTC) #26
alph
Awesome! LGTM
4 years, 2 months ago (2016-10-10 18:21:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406703002/40001
4 years, 2 months ago (2016-10-10 18:30:51 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-10 19:57:48 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 20:02:05 UTC) #34
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7bc681e5c39bda0926e77961273916dc90530558
Cr-Commit-Position: refs/heads/master@{#424212}

Powered by Google App Engine
This is Rietveld 408576698