Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2397373003: tracing: remove UNSHIPPED_TRACE_EVENT (Closed)

Created:
4 years, 2 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing: remove UNSHIPPED_TRACE_EVENT Curently there is only one use case for UNSHIPPED_TRACE_EVENT* in the codebase and that doesn't justify adding another dimension to the combinatorial bloat of the tracing macros. Just moving the OFFICIAL_BUILD check to the only use case. BUG= Committed: https://crrev.com/176b8d6a757b6efd27f49035171a9e9f3ebeaedf Cr-Commit-Position: refs/heads/master@{#423904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -44 lines) Patch
M base/trace_event/common/trace_event_common.h View 1 chunk +0 lines, -43 lines 0 comments Download
M chrome/browser/android/compositor/compositor_view.cc View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
Primiano Tucci (use gerrit)
4 years, 2 months ago (2016-10-07 15:38:05 UTC) #5
David Trainor- moved to gerrit
lgtm thanks!
4 years, 2 months ago (2016-10-07 17:47:25 UTC) #6
oystein (OOO til 10th of July)
ALL of the lgtms!
4 years, 2 months ago (2016-10-07 17:49:56 UTC) #9
oystein (OOO til 10th of July)
On 2016/10/07 17:49:56, oystein wrote: > ALL of the lgtms! And apparently that doesn't work ...
4 years, 2 months ago (2016-10-07 17:50:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397373003/1
4 years, 2 months ago (2016-10-07 17:50:45 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 17:56:56 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 17:58:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/176b8d6a757b6efd27f49035171a9e9f3ebeaedf
Cr-Commit-Position: refs/heads/master@{#423904}

Powered by Google App Engine
This is Rietveld 408576698