Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2406623002: Revert of [parser] Deprecate ParseInfo constructor taking closure. (Closed)

Created:
4 years, 2 months ago by Michael Hablich
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [parser] Deprecate ParseInfo constructor taking closure. (patchset #2 id:20001 of https://codereview.chromium.org/2396963003/ ) Reason for revert: Needed to revert https://codereview.chromium.org/2400343002/ Original issue's description: > [parser] Deprecate ParseInfo constructor taking closure. > > This removes the {ParseInfo} constructor consuming a closure, replacing > all uses to pass only the shared function info. The goal is to make the > fact that parsing is independent of a concrete closure explicit. > > R=jochen@chromium.org > BUG=v8:2206 > > Committed: https://crrev.com/3de42b3f224217ec88e4c609d3cf23fe06806dca > Cr-Commit-Position: refs/heads/master@{#40083} TBR=jochen@chromium.org,bmeurer@chromium.org,marja@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2206 Committed: https://crrev.com/234f1a84b74b00d664ec44424382412f2a6e19f4 Cr-Commit-Position: refs/heads/master@{#40097}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -18 lines) Patch
M src/compiler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parse-info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/parse-info.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/function-tester.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-linkage.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of [parser] Deprecate ParseInfo constructor taking closure.
4 years, 2 months ago (2016-10-07 21:13:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2406623002/1
4 years, 2 months ago (2016-10-07 21:13:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 21:13:19 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 21:13:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/234f1a84b74b00d664ec44424382412f2a6e19f4
Cr-Commit-Position: refs/heads/master@{#40097}

Powered by Google App Engine
This is Rietveld 408576698