Automatically identify the workspace suffix for READONLY.

Automatically identify the workspace suffix for READONLY.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/51f617c0d31907a660b7fb6385873242c6a3ad38

[Paul Berry, 2016-10-07 20:44:38]

https://codereview.chromium.org/2406603002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/bazel.dart (right):

https://codereview.chromium.org/2406603002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/bazel.dart:211: return null;
Do we really want to return `null` at this point?  It seems like it would be
better to continue on to line 228, so that if the user's project happens to
contain a folder called "READONLY" in it, we won't be fooled.

https://codereview.chromium.org/2406603002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/bazel.dart:216: return null;
Similar issue here.

[Brian Wilkerson, 2016-10-07 20:54:31]

lgtm

[scheglov, 2016-10-07 21:02:50]

https://codereview.chromium.org/2406603002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/bazel.dart (right):

https://codereview.chromium.org/2406603002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/bazel.dart:211: return null;
On 2016/10/07 20:44:38, Paul Berry wrote:
> Do we really want to return `null` at this point?  It seems like it would be
> better to continue on to line 228, so that if the user's project happens to
> contain a folder called "READONLY" in it, we won't be fooled.

Done.

[Paul Berry, 2016-10-07 21:14:33]

lgtm

[scheglov, 2016-10-07 21:24:15]

Description was changed from

==========
Automatically identify the workspace suffix for READONLY.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Automatically identify the workspace suffix for READONLY.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/51f617c0d31907a660b7fb6385873242c6a3ad38
==========

[scheglov, 2016-10-07 21:24:16]

Committed patchset #2 (id:20001) manually as
51f617c0d31907a660b7fb6385873242c6a3ad38 (presubmit successful).