Automatically identify the workspace suffix for READONLY.

pkg/analyzer/test/generated/bazel_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.bazel_test;
 
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/src/generated/bazel.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:test/test.dart';
@@ skipping 175 matching lines @@
     Source source = resolver.resolveAbsolute(uri);
     expect(source, isNotNull);
     expect(source.fullName, _p(posixPath));
     expect(source.uri, uri);
     expect(source.exists(), exists);
   }
 }
 
 @reflectiveTest
 class BazelWorkspaceTest extends _BaseTest {
-  void test_factory_null_noWorkspaceMarkers_inRoot() {
-    BazelWorkspace workspace = BazelWorkspace.find(provider, _p('/'));
-    expect(workspace, isNull);
-  }
-
-  void test_factory_null_noWorkspaceMarkers_inRoot_withReadonly() {
-    BazelWorkspace workspace =
-        BazelWorkspace.find(provider, _p('/'), readonlySuffix: 'READONLY');
-    expect(workspace, isNull);
-  }
-
   void test_find_fail_notAbsolute() {
     expect(() => BazelWorkspace.find(provider, _p('not_absolute')),
         throwsArgumentError);
   }
 
   void test_find_hasReadonlyFolder() {
     provider.newFolder(_p('/Users/user/test/READONLY/prime'));
     provider.newFolder(_p('/Users/user/test/prime'));
     provider.newFolder(_p('/Users/user/test/prime/bazel-genfiles'));
-    BazelWorkspace workspace = BazelWorkspace.find(
-        provider, _p('/Users/user/test/prime/my/module'),
-        readonlySuffix: 'prime');
+    BazelWorkspace workspace =
+        BazelWorkspace.find(provider, _p('/Users/user/test/prime/my/module'));
     expect(workspace.root, _p('/Users/user/test/prime'));
     expect(workspace.readonly, _p('/Users/user/test/READONLY/prime'));
     expect(workspace.bin, _p('/Users/user/test/prime/bazel-bin'));
     expect(workspace.genfiles, _p('/Users/user/test/prime/bazel-genfiles'));
   }
 
+  void test_find_hasReadonlyFolder_bad_actuallyHasWorkspaceFile() {
+    provider.newFolder(_p('/Users/user/test/READONLY'));
+    provider.newFile(_p('/Users/user/test/prime/WORKSPACE'), '');
+    provider.newFolder(_p('/Users/user/test/prime/bazel-genfiles'));
+    BazelWorkspace workspace =
+        BazelWorkspace.find(provider, _p('/Users/user/test/prime/my/module'));
+    expect(workspace.root, _p('/Users/user/test/prime'));
+    expect(workspace.readonly, isNull);
+    expect(workspace.bin, _p('/Users/user/test/prime/bazel-bin'));
+    expect(workspace.genfiles, _p('/Users/user/test/prime/bazel-genfiles'));
+  }
+
   void test_find_hasReadonlyFolder_blaze() {
     provider.newFolder(_p('/Users/user/test/READONLY/prime'));
     provider.newFolder(_p('/Users/user/test/prime'));
     provider.newFolder(_p('/Users/user/test/prime/blaze-genfiles'));
-    BazelWorkspace workspace = BazelWorkspace.find(
-        provider, _p('/Users/user/test/prime/my/module'),
-        readonlySuffix: 'prime');
+    BazelWorkspace workspace =
+        BazelWorkspace.find(provider, _p('/Users/user/test/prime/my/module'));
     expect(workspace.root, _p('/Users/user/test/prime'));
     expect(workspace.readonly, _p('/Users/user/test/READONLY/prime'));
     expect(workspace.bin, _p('/Users/user/test/prime/blaze-bin'));
     expect(workspace.genfiles, _p('/Users/user/test/prime/blaze-genfiles'));
   }
 
   void test_find_hasWorkspaceFile() {
     provider.newFile(_p('/workspace/WORKSPACE'), '');
     provider.newFolder(_p('/workspace/bazel-genfiles'));
     BazelWorkspace workspace =
@@ skipping 39 matching lines @@
     BazelWorkspace workspace =
         BazelWorkspace.find(provider, _p('/workspace/my/module'));
     expect(workspace, isNull);
   }
 
   void test_find_null_noWorkspaceMarkers_inRoot() {
     BazelWorkspace workspace = BazelWorkspace.find(provider, _p('/'));
     expect(workspace, isNull);
   }
 
-  void test_find_null_noWorkspaceMarkers_inRoot_withReadonly() {
-    BazelWorkspace workspace =
-        BazelWorkspace.find(provider, _p('/'), readonlySuffix: 'READONLY');
-    expect(workspace, isNull);
-  }
-
   void test_find_null_symlinkPrefix() {
     provider.newFile(_p('/workspace/WORKSPACE'), '');
     BazelWorkspace workspace =
         BazelWorkspace.find(provider, _p('/workspace/my/module'));
     expect(workspace, isNull);
   }
 
   void test_findFile_hasReadonlyFolder() {
     provider.newFolder(_p('/Users/user/test/READONLY/prime'));
     provider.newFolder(_p('/Users/user/test/prime'));
     provider.newFile(_p('/Users/user/test/prime/my/module/test1.dart'), '');
     provider.newFile(_p('/Users/user/test/prime/my/module/test2.dart'), '');
     provider.newFile(_p('/Users/user/test/prime/my/module/test3.dart'), '');
     provider.newFile(
         _p('/Users/user/test/prime/bazel-bin/my/module/test2.dart'), '');
     provider.newFile(
         _p('/Users/user/test/prime/bazel-genfiles/my/module/test3.dart'), '');
     provider.newFile(
         _p('/Users/user/test/READONLY/prime/other/module/test4.dart'), '');
-    BazelWorkspace workspace = BazelWorkspace.find(
-        provider, _p('/Users/user/test/prime/my/module'),
-        readonlySuffix: 'prime');
+    BazelWorkspace workspace =
+        BazelWorkspace.find(provider, _p('/Users/user/test/prime/my/module'));
     expect(
         workspace
             .findFile(_p('/Users/user/test/prime/my/module/test1.dart'))
             .path,
         _p('/Users/user/test/prime/my/module/test1.dart'));
     expect(
         workspace
             .findFile(_p('/Users/user/test/prime/my/module/test2.dart'))
             .path,
         _p('/Users/user/test/prime/bazel-bin/my/module/test2.dart'));
@@ skipping 28 matching lines @@
 }
 
 class _BaseTest {
   final MemoryResourceProvider provider = new MemoryResourceProvider();
 
   /**
    * Return the [provider] specific path for the given Posix [path].
    */
   String _p(String path) => provider.convertPath(path);
 }