Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: components/ntp_snippets/category_factory_unittest.cc

Issue 2406573002: 📰 Persist category dismissals (Closed)
Patch Set: rebase, address comments, add test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_snippets/category_factory.cc ('k') | components/ntp_snippets/content_suggestions_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/category_factory_unittest.cc
diff --git a/components/ntp_snippets/category_factory_unittest.cc b/components/ntp_snippets/category_factory_unittest.cc
index 6ffd149b79eeb386ccfda80b2011aff13b52004e..b600c88b85d71a3d3b059a32cc269e96337f5155 100644
--- a/components/ntp_snippets/category_factory_unittest.cc
+++ b/components/ntp_snippets/category_factory_unittest.cc
@@ -15,7 +15,8 @@ namespace ntp_snippets {
class CategoryFactoryTest : public testing::Test {
public:
- CategoryFactoryTest() : unused_remote_category_id_(1) {}
+ // Note: uses 2 as first remote category id as 1 is used for |ARTICLES|
+ CategoryFactoryTest() : unused_remote_category_id_(2) {}
Bernhard Bauer 2016/10/17 16:52:04 Nit: You could just use ARTICLES + 1 :)
dgn 2016/10/17 17:12:29 Done. Added LAST_KNOWN_REMOTE_CATEGORY for this.
int GetUnusedRemoteCategoryID() { return unused_remote_category_id_++; }
« no previous file with comments | « components/ntp_snippets/category_factory.cc ('k') | components/ntp_snippets/content_suggestions_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698