📰 Persist category dismissals

components/ntp_snippets/category_factory_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/category_factory.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "components/ntp_snippets/category.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace ntp_snippets {
 
 class CategoryFactoryTest : public testing::Test {
  public:
-  CategoryFactoryTest() : unused_remote_category_id_(1) {}
+  // Note: uses 2 as first remote category id as 1 is used for |ARTICLES|
+  CategoryFactoryTest() : unused_remote_category_id_(2) {}

[Bernhard Bauer, 2016/10/17 16:52:04]

Nit: You could just use ARTICLES + 1 :)

[dgn, 2016/10/17 17:12:29]

Done. Added LAST_KNOWN_REMOTE_CATEGORY for this.

 
   int GetUnusedRemoteCategoryID() { return unused_remote_category_id_++; }
 
   bool CompareCategories(const Category& left, const Category& right) {
     return factory()->CompareCategories(left, right);
   }
 
   void AddDummyRemoteCategories(int quantity) {
     for (int i = 0; i < quantity; ++i) {
       factory()->FromRemoteCategory(GetUnusedRemoteCategoryID());
@@ skipping 88 matching lines @@
   AddDummyRemoteCategories(3);
 
   EXPECT_TRUE(CompareCategories(consequtive_first, consequtive_second));
   EXPECT_FALSE(CompareCategories(consequtive_second, consequtive_first));
 
   EXPECT_TRUE(CompareCategories(nonconsequtive_first, nonconsequtive_second));
   EXPECT_FALSE(CompareCategories(nonconsequtive_second, nonconsequtive_first));
 }
 
 }  // namespace ntp_snippets