Issue 2406423005: [Merge M54] Switching from CLD3 to CLD2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2406423005: [Merge M54] Switching from CLD3 to CLD2 (Closed)

Created:
4 years, 2 months ago by please use gerrit instead

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

[Merge M54] Switching from CLD3 to CLD2 This is accomplished by: - flipping the flag in third_party/cld/BUILD.gn - listing explicitly source files in third_party/cld_2/BUILD.gn that were originally retrieved from the following gyp file which got removed during the transition away from GYP: https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d8968635cfef2/third_party/cld_2/cld_2.gyp BUG=653881 Review-Url: https://codereview.chromium.org/2396183002 Cr-Commit-Position: refs/heads/master@{#423855} (cherry picked from commit 13cff7269b9e76b0f77ecb94eade1dfee02e6a32) Committed: https://chromium.googlesource.com/chromium/src/+/fafcc418d3e49f2d99f246effdb39499e100e84f

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -10 lines)			Patch
	M	third_party/cld/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/cld_2/BUILD.gn	View		3 chunks	+55 lines, -9 lines	0 comments	Download

Total messages: 2 (1 generated)

please use gerrit instead

4 years, 2 months ago (2016-10-11 20:10:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fafcc418d3e49f2d99f246effdb39499e100e84f.