Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2396183002: Switching from CLD3 to CLD2 (Closed)

Created:
4 years, 2 months ago by Anton Bakalov
Modified:
4 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, groby-ooo-7-16, djweiss1, riesa
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switching from CLD3 to CLD2 This is accomplished by: - flipping the flag in third_party/cld/BUILD.gn - listing explicitly source files in third_party/cld_2/BUILD.gn that were originally retrieved from the following gyp file which got removed during the transition away from GYP: https://chromium.googlesource.com/chromium/src/+/4b56905d6ab61e9e14f991a7458d8968635cfef2/third_party/cld_2/cld_2.gyp BUG=653881 Committed: https://crrev.com/13cff7269b9e76b0f77ecb94eade1dfee02e6a32 Cr-Commit-Position: refs/heads/master@{#423855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -10 lines) Patch
M third_party/cld/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cld_2/BUILD.gn View 3 chunks +55 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Anton Bakalov
4 years, 2 months ago (2016-10-06 21:10:37 UTC) #6
brettw
lgtm
4 years, 2 months ago (2016-10-06 21:12:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396183002/1
4 years, 2 months ago (2016-10-07 14:32:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 14:38:24 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13cff7269b9e76b0f77ecb94eade1dfee02e6a32 Cr-Commit-Position: refs/heads/master@{#423855}
4 years, 2 months ago (2016-10-07 14:39:37 UTC) #16
Anton Bakalov
4 years, 2 months ago (2016-10-07 17:14:27 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2400273002/ by abakalov@chromium.org.

The reason for reverting is: We created this CL, so that we can merge it into
M54 and switch from CLD3 to CLD2. I am reverting it now to continue testing CLD3
in M55..

Powered by Google App Engine
This is Rietveld 408576698