Issue 2406353002: Validate patch file paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2406353002: Validate patch file paths. (Closed)

Created:
4 years, 2 months ago by scheglov

Modified:
4 years, 2 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Validate patch file paths. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f233d759a27135596b1c8de07bd7e9b462b33286

Patch Set 1 #

Total comments: 1

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -1 line)			Patch
	M	pkg/analyzer/lib/src/generated/sdk.dart	View		3 chunks	+22 lines, -1 line	1 comment	Download
	M	pkg/analyzer/test/src/dart/sdk/sdk_test.dart	View		2 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm with one minor nit https://codereview.chromium.org/2406353002/diff/1/pkg/analyzer/lib/src/generated/sdk.dart File pkg/analyzer/lib/src/generated/sdk.dart (right): https://codereview.chromium.org/2406353002/diff/1/pkg/analyzer/lib/src/generated/sdk.dart#newcode467 pkg/analyzer/lib/src/generated/sdk.dart:467: if (pathos.isAbsolute(path)) { Use ...

4 years, 2 months ago (2016-10-11 16:57:51 UTC) #2

scheglov

4 years, 2 months ago (2016-10-11 17:07:43 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f233d759a27135596b1c8de07bd7e9b462b33286 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages