Validate patch file paths.

pkg/analyzer/test/src/dart/sdk/sdk_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.sdk_test;
 
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'package:analyzer/src/context/builder.dart' show EmbedderYamlLocator;
 import 'package:analyzer/src/dart/sdk/sdk.dart';
@@ skipping 509 matching lines @@
           r'''
 final Map<String, LibraryInfo> LIBRARIES = const <String, LibraryInfo> {
   'foo' : const LibraryInfo(
     'foo/foo.dart',
     patches: {
       VM_PLATFORM: [42]}),
 };''');
     }, throwsArgumentError);
   }
 
+  void test_readFrom_patches_invalid_path_hasDotDot() {
+    _assertPathIsInvalid('foo/../bar.dart');
+    _assertPathIsInvalid('../foo/bar.dart');
+    _assertPathIsInvalid('foo/bar..dart');
+  }
+
+  void test_readFrom_patches_invalid_path_isAbsolute() {
+    _assertPathIsInvalid('/foo.dart');
+    _assertPathIsInvalid('/foo/bar.dart');
+  }
+
+  void test_readFrom_patches_invalid_path_notPosix() {
+    _assertPathIsInvalid(r'foo\bar.dart');
+  }
+
   void test_readFrom_patches_invalid_platformCombinator() {
     expect(() {
       new SdkLibrariesReader(false).readFromFile(
           resourceProvider.getFile('/libs.dart'),
           r'''
 final Map<String, LibraryInfo> LIBRARIES = const <String, LibraryInfo> {
   'foo' : const LibraryInfo(
     'foo/foo.dart',
     patches: {
       DART2JS_PLATFORM + VM_PLATFORM: ['X']}),
@@ skipping 24 matching lines @@
 };''');
     expect(libraryMap, isNotNull);
     expect(libraryMap.size(), 1);
     SdkLibrary library = libraryMap.getLibrary('dart:my');
     expect(library, isNotNull);
     expect(library.path, 'my/my.dart');
     expect(library.shortName, 'dart:my');
     expect(library.getPatches(SdkLibraryImpl.VM_PLATFORM), isEmpty);
     expect(library.getPatches(SdkLibraryImpl.DART2JS_PLATFORM), isEmpty);
   }
+
+  void _assertPathIsInvalid(String patchPath) {
+    expect(() {
+      new SdkLibrariesReader(false).readFromFile(
+          resourceProvider.getFile('/libs.dart'),
+          '''
+final Map<String, LibraryInfo> LIBRARIES = const <String, LibraryInfo> {
+  'foo' : const LibraryInfo(
+    'foo/foo.dart',
+    patches: {
+      VM_PLATFORM: [r'$patchPath']}),
+};''');
+    }, throwsArgumentError);
+  }
 }
 
 @reflectiveTest
 class SdkLibraryImplTest extends EngineTestCase {
   void test_patches() {
     SdkLibraryImpl library = new SdkLibraryImpl('dart:foo');
     // Set patches.
     library.setPatchPaths(
         SdkLibraryImpl.DART2JS_PLATFORM | SdkLibraryImpl.VM_PLATFORM,
         ['a', 'b']);
     library.setPatchPaths(SdkLibraryImpl.DART2JS_PLATFORM, ['c', 'd']);
     library.setPatchPaths(SdkLibraryImpl.VM_PLATFORM, ['e']);
     // Get patches.
     expect(library.getPatches(SdkLibraryImpl.DART2JS_PLATFORM),
         unorderedEquals(['a', 'b', 'c', 'd']));
     expect(library.getPatches(SdkLibraryImpl.VM_PLATFORM),
         unorderedEquals(['a', 'b', 'e']));
   }
 }