Chromium Code Reviews Chromium Code Reviews
Issue 2406343002:
[promises] Move PromiseReactionJob to c++ (Closed)
| Index: src/objects.h |
| diff --git a/src/objects.h b/src/objects.h |
| index f77ac4bc8ea3664643a20395b970e03ab8a6ece3..04245dd4033aca68a15ef5aeff5fe8720829b3eb 100644 |
| --- a/src/objects.h |
| +++ b/src/objects.h |
| @@ -143,6 +143,8 @@ |
| // - Struct |
| // - Box |
| // - AccessorInfo |
| +// - PromiseContainer |
| +// - PromiseHandleInfo |
| // - AccessorPair |
| // - AccessCheckInfo |
| // - InterceptorInfo |
| @@ -399,6 +401,7 @@ const int kStubMinorKeyBits = kSmiValueSize - kStubMajorKeyBits - 1; |
| V(ALIASED_ARGUMENTS_ENTRY_TYPE) \ |
| V(BOX_TYPE) \ |
| V(PROMISE_CONTAINER_TYPE) \ |
| + V(PROMISE_HANDLE_INFO_TYPE) \ |
| V(PROTOTYPE_INFO_TYPE) \ |
| V(CONTEXT_EXTENSION_TYPE) \ |
| V(MODULE_TYPE) \ |
| @@ -506,6 +509,7 @@ const int kStubMinorKeyBits = kSmiValueSize - kStubMajorKeyBits - 1; |
| #define STRUCT_LIST(V) \ |
| V(BOX, Box, box) \ |
| V(PROMISE_CONTAINER, PromiseContainer, promise_container) \ |
| + V(PROMISE_HANDLE_INFO, PromiseHandleInfo, promise_handle_info) \ |
| V(ACCESSOR_INFO, AccessorInfo, accessor_info) \ |
| V(ACCESSOR_PAIR, AccessorPair, accessor_pair) \ |
| V(ACCESS_CHECK_INFO, AccessCheckInfo, access_check_info) \ |
| @@ -688,6 +692,7 @@ enum InstanceType { |
| ALIASED_ARGUMENTS_ENTRY_TYPE, |
| BOX_TYPE, |
| PROMISE_CONTAINER_TYPE, |
| + PROMISE_HANDLE_INFO_TYPE, |
| DEBUG_INFO_TYPE, |
| BREAK_POINT_INFO_TYPE, |
| FIXED_ARRAY_TYPE, |
| @@ -6678,8 +6683,7 @@ class Struct: public HeapObject { |
| }; |
| // A container struct to hold state required for |
| -// PromiseResolveThenableJob. {before, after}_debug_event could |
| -// potentially be undefined if the debugger is turned off. |
| +// PromiseResolveThenableJob. |
| class PromiseContainer : public Struct { |
|
adamk
2016/10/11 23:14:30
This name now sounds too generic. Maybe add a TODO
gsathya
2016/10/12 02:00:44
Done.
|
| public: |
| DECL_ACCESSORS(thenable, JSReceiver) |
| @@ -6706,6 +6710,33 @@ class PromiseContainer : public Struct { |
| DISALLOW_IMPLICIT_CONSTRUCTORS(PromiseContainer); |
| }; |
| +// Struct to hold state required for PromiseReactionJob. |
| +class PromiseHandleInfo : public Struct { |
|
adamk
2016/10/11 23:14:30
This name is a little funny; why not PromiseReacti
gsathya
2016/10/12 02:00:44
Done.
|
| + public: |
| + DECL_ACCESSORS(value, Object) |
| + DECL_ACCESSORS(tasks, Object) |
| + DECL_ACCESSORS(deferred, Object) |
|
adamk
2016/10/11 23:14:30
Isn't this guaranteed to be a JSObject?
gsathya
2016/10/12 02:00:44
Nope this can be UNDEFINED when we have more than
|
| + DECL_ACCESSORS(before_debug_event, Object) |
| + DECL_ACCESSORS(after_debug_event, Object) |
| + DECL_ACCESSORS(reaction_context, Context) |
|
adamk
2016/10/11 23:14:30
I think "context" would be a fine name for this.
gsathya
2016/10/12 02:00:44
Done.
|
| + |
| + static const int kValueOffset = Struct::kHeaderSize; |
| + static const int kTasksOffset = kValueOffset + kPointerSize; |
| + static const int kDeferredOffset = kTasksOffset + kPointerSize; |
| + static const int kBeforeDebugEventOffset = kDeferredOffset + kPointerSize; |
| + static const int kAfterDebugEventOffset = |
| + kBeforeDebugEventOffset + kPointerSize; |
| + static const int kReactionContext = kAfterDebugEventOffset + kPointerSize; |
| + static const int kSize = kReactionContext + kPointerSize; |
| + |
| + DECLARE_CAST(PromiseHandleInfo) |
| + DECLARE_PRINTER(PromiseHandleInfo) |
| + DECLARE_VERIFIER(PromiseHandleInfo) |
| + |
| + private: |
| + DISALLOW_IMPLICIT_CONSTRUCTORS(PromiseHandleInfo); |
| +}; |
| + |
| // A simple one-element struct, useful where smis need to be boxed. |
| class Box : public Struct { |
| public: |
