[promises] Move PromiseReactionJob to c++

src/objects.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_OBJECTS_H_
 #define V8_OBJECTS_H_
 
 #include <iosfwd>
 #include <memory>
 
@@ skipping 125 matching lines @@
 //     - PropertyCell
 //     - Code
 //     - AbstractCode, a wrapper around Code or BytecodeArray
 //     - Map
 //     - Oddball
 //     - Foreign
 //     - SharedFunctionInfo
 //     - Struct
 //       - Box
 //       - AccessorInfo
+//       - PromiseContainer
+//       - PromiseHandleInfo
 //       - AccessorPair
 //       - AccessCheckInfo
 //       - InterceptorInfo
 //       - CallHandlerInfo
 //       - TemplateInfo
 //         - FunctionTemplateInfo
 //         - ObjectTemplateInfo
 //       - Script
 //       - DebugInfo
 //       - BreakPointInfo
@@ skipping 236 matching lines @@
   V(OBJECT_TEMPLATE_INFO_TYPE)                                  \
   V(SIGNATURE_INFO_TYPE)                                        \
   V(TYPE_SWITCH_INFO_TYPE)                                      \
   V(ALLOCATION_MEMENTO_TYPE)                                    \
   V(ALLOCATION_SITE_TYPE)                                       \
   V(SCRIPT_TYPE)                                                \
   V(TYPE_FEEDBACK_INFO_TYPE)                                    \
   V(ALIASED_ARGUMENTS_ENTRY_TYPE)                               \
   V(BOX_TYPE)                                                   \
   V(PROMISE_CONTAINER_TYPE)                                     \
+  V(PROMISE_HANDLE_INFO_TYPE)                                   \
   V(PROTOTYPE_INFO_TYPE)                                        \
   V(CONTEXT_EXTENSION_TYPE)                                     \
   V(MODULE_TYPE)                                                \
                                                                 \
   V(FIXED_ARRAY_TYPE)                                           \
   V(FIXED_DOUBLE_ARRAY_TYPE)                                    \
   V(SHARED_FUNCTION_INFO_TYPE)                                  \
   V(WEAK_CELL_TYPE)                                             \
   V(TRANSITION_ARRAY_TYPE)                                      \
                                                                 \
@@ skipping 87 matching lines @@
 // code for the class including allocation and garbage collection routines,
 // casts and predicates.  All you need to define is the class, methods and
 // object verification routines.  Easy, no?
 //
 // Note that for subtle reasons related to the ordering or numerical values of
 // type tags, elements in this list have to be added to the INSTANCE_TYPE_LIST
 // manually.
 #define STRUCT_LIST(V)                                                       \
   V(BOX, Box, box)                                                           \
   V(PROMISE_CONTAINER, PromiseContainer, promise_container)                  \
+  V(PROMISE_HANDLE_INFO, PromiseHandleInfo, promise_handle_info)             \
   V(ACCESSOR_INFO, AccessorInfo, accessor_info)                              \
   V(ACCESSOR_PAIR, AccessorPair, accessor_pair)                              \
   V(ACCESS_CHECK_INFO, AccessCheckInfo, access_check_info)                   \
   V(INTERCEPTOR_INFO, InterceptorInfo, interceptor_info)                     \
   V(CALL_HANDLER_INFO, CallHandlerInfo, call_handler_info)                   \
   V(FUNCTION_TEMPLATE_INFO, FunctionTemplateInfo, function_template_info)    \
   V(OBJECT_TEMPLATE_INFO, ObjectTemplateInfo, object_template_info)          \
   V(SCRIPT, Script, script)                                                  \
   V(ALLOCATION_SITE, AllocationSite, allocation_site)                        \
   V(ALLOCATION_MEMENTO, AllocationMemento, allocation_memento)               \
@@ skipping 162 matching lines @@
   OBJECT_TEMPLATE_INFO_TYPE,
   SIGNATURE_INFO_TYPE,
   TYPE_SWITCH_INFO_TYPE,
   ALLOCATION_SITE_TYPE,
   ALLOCATION_MEMENTO_TYPE,
   SCRIPT_TYPE,
   TYPE_FEEDBACK_INFO_TYPE,
   ALIASED_ARGUMENTS_ENTRY_TYPE,
   BOX_TYPE,
   PROMISE_CONTAINER_TYPE,
+  PROMISE_HANDLE_INFO_TYPE,
   DEBUG_INFO_TYPE,
   BREAK_POINT_INFO_TYPE,
   FIXED_ARRAY_TYPE,
   SHARED_FUNCTION_INFO_TYPE,
   CELL_TYPE,
   WEAK_CELL_TYPE,
   TRANSITION_ARRAY_TYPE,
   PROPERTY_CELL_TYPE,
   PROTOTYPE_INFO_TYPE,
   CONTEXT_EXTENSION_TYPE,
@@ skipping 5970 matching lines @@
 // An abstract superclass, a marker class really, for simple structure classes.
 // It doesn't carry much functionality but allows struct classes to be
 // identified in the type system.
 class Struct: public HeapObject {
  public:
   inline void InitializeBody(int object_size);
   DECLARE_CAST(Struct)
 };
 
 // A container struct to hold state required for
-// PromiseResolveThenableJob. {before, after}_debug_event could
-// potentially be undefined if the debugger is turned off.
+// PromiseResolveThenableJob.
 class PromiseContainer : public Struct {

[adamk, 2016/10/11 23:14:30]

This name now sounds too generic. Maybe add a TODO to rename it?

[gsathya, 2016/10/12 02:00:44]

Done.

  public:
   DECL_ACCESSORS(thenable, JSReceiver)
   DECL_ACCESSORS(then, JSReceiver)
   DECL_ACCESSORS(resolve, JSFunction)
   DECL_ACCESSORS(reject, JSFunction)
   DECL_ACCESSORS(before_debug_event, Object)
   DECL_ACCESSORS(after_debug_event, Object)
 
   static const int kThenableOffset = Struct::kHeaderSize;
   static const int kThenOffset = kThenableOffset + kPointerSize;
   static const int kResolveOffset = kThenOffset + kPointerSize;
   static const int kRejectOffset = kResolveOffset + kPointerSize;
   static const int kBeforeDebugEventOffset = kRejectOffset + kPointerSize;
   static const int kAfterDebugEventOffset =
       kBeforeDebugEventOffset + kPointerSize;
   static const int kSize = kAfterDebugEventOffset + kPointerSize;
 
   DECLARE_CAST(PromiseContainer)
   DECLARE_PRINTER(PromiseContainer)
   DECLARE_VERIFIER(PromiseContainer)
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PromiseContainer);
 };
 
+// Struct to hold state required for PromiseReactionJob.
+class PromiseHandleInfo : public Struct {

[adamk, 2016/10/11 23:14:30]

This name is a little funny; why not PromiseReactionJobInfo?

[gsathya, 2016/10/12 02:00:44]

Done.

+ public:
+  DECL_ACCESSORS(value, Object)
+  DECL_ACCESSORS(tasks, Object)
+  DECL_ACCESSORS(deferred, Object)

[adamk, 2016/10/11 23:14:30]

Isn't this guaranteed to be a JSObject?

[gsathya, 2016/10/12 02:00:44]

Nope this can be UNDEFINED when we have more than one callback. The comment in
PromiseReactionJob explains this. Happy to add another comment here if you think
that's useful.

+  DECL_ACCESSORS(before_debug_event, Object)
+  DECL_ACCESSORS(after_debug_event, Object)
+  DECL_ACCESSORS(reaction_context, Context)

[adamk, 2016/10/11 23:14:30]

I think "context" would be a fine name for this.

[gsathya, 2016/10/12 02:00:44]

Done.

+
+  static const int kValueOffset = Struct::kHeaderSize;
+  static const int kTasksOffset = kValueOffset + kPointerSize;
+  static const int kDeferredOffset = kTasksOffset + kPointerSize;
+  static const int kBeforeDebugEventOffset = kDeferredOffset + kPointerSize;
+  static const int kAfterDebugEventOffset =
+      kBeforeDebugEventOffset + kPointerSize;
+  static const int kReactionContext = kAfterDebugEventOffset + kPointerSize;
+  static const int kSize = kReactionContext + kPointerSize;
+
+  DECLARE_CAST(PromiseHandleInfo)
+  DECLARE_PRINTER(PromiseHandleInfo)
+  DECLARE_VERIFIER(PromiseHandleInfo)
+
+ private:
+  DISALLOW_IMPLICIT_CONSTRUCTORS(PromiseHandleInfo);
+};
+
 // A simple one-element struct, useful where smis need to be boxed.
 class Box : public Struct {
  public:
   // [value]: the boxed contents.
   DECL_ACCESSORS(value, Object)
 
   DECLARE_CAST(Box)
 
   // Dispatched behavior.
   DECLARE_PRINTER(Box)
@@ skipping 4731 matching lines @@
     }
     return value;
   }
 };
 
 
 }  // NOLINT, false-positive due to second-order macros.
 }  // NOLINT, false-positive due to second-order macros.
 
 #endif  // V8_OBJECTS_H_