chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc - Issue 2406303003: Move enable_app_list to a buildflag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

Issue 2406303003: Move enable_app_list to a buildflag. (Closed)

Patch Set: More grit defines Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc ('k') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

index 0a86b3e66aa9a89cd1ed570626729c1f3f419775..c31f0fa70b96223a7fceaafa31c14376f4f1358f 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_views.cc

@@ -18,6 +18,7 @@

#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_constants.h"

+#include "chrome/common/features.h"

#include "components/constrained_window/constrained_window_views.h"

#include "content/public/browser/web_contents.h"

#include "extensions/browser/extension_registry.h"

@@ -70,7 +71,7 @@ gfx::Size GetAppInfoNativeDialogSize() {

return gfx::Size(380, 490);

}

-#if defined(ENABLE_APP_LIST)

+#if BUILDFLAG(ENABLE_APP_LIST)

void ShowAppInfoInAppList(gfx::NativeWindow parent,

const gfx::Rect& app_list_bounds,

Profile* profile,