third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp - Issue 2406163004: Simplify the usage of PositionWithAffinity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

Issue 2406163004: Simplify the usage of PositionWithAffinity (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

index c2fd4ca90b4d36b105dfd6d46ce602051769c8dc..c153d2ddc0076e39e10950bc888a68011fef8fc9 100644

--- a/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp

@@ -359,8 +359,7 @@ void IndentOutdentCommand::outdentRegion(

break;

document().updateStyleAndLayoutIgnorePendingStylesheets();

- if (endOfNextParagraph.isNotNull() &&

- !endOfNextParagraph.position().isConnected()) {

+ if (endOfNextParagraph.isNotNull() && !endOfNextParagraph.isConnected()) {

endOfCurrentParagraph = createVisiblePosition(endingSelection().end());

endOfNextParagraph = endOfParagraph(nextPositionOf(endOfCurrentParagraph))

.toPositionWithAffinity();