third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp - Issue 2406163004: Simplify the usage of PositionWithAffinity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

Issue 2406163004: Simplify the usage of PositionWithAffinity (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

index d9d2bd2ca3645ae6735577a7f8662c36f38f31f4..510ebf148c61bfe1822878fee1f804fbcb9e94c5 100644

--- a/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommand.cpp

@@ -186,10 +186,9 @@ void ApplyBlockElementCommand::formatSelection(

if (endAfterSelection.isNotNull() && !endAfterSelection.isConnected())

break;

// Sanity check: Make sure our moveParagraph calls didn't remove

- // endOfNextParagraph.position().anchorNode() If somehow, e.g. mutation

+ // endOfNextParagraph.anchorNode() If somehow, e.g. mutation

// event handler, we did, return to prevent crashes.

- if (endOfNextParagraph.isNotNull() &&

- !endOfNextParagraph.position().isConnected())

+ if (endOfNextParagraph.isNotNull() && !endOfNextParagraph.isConnected())

return;

document().updateStyleAndLayoutIgnorePendingStylesheets();