[wasm] Decouple function name and exported name in WasmFunctionBuilder

src/asmjs/asm-wasm-builder.cc

Index: src/asmjs/asm-wasm-builder.cc
diff --git a/src/asmjs/asm-wasm-builder.cc b/src/asmjs/asm-wasm-builder.cc
index 47545876b1afc82170347375869d8693485c637f..89fa58679c452e1a85520b645b992aed40f48ede 100644
--- a/src/asmjs/asm-wasm-builder.cc
+++ b/src/asmjs/asm-wasm-builder.cc
@@ -564,8 +564,7 @@ class AsmWasmBuilderImpl final : public AstVisitor<AsmWasmBuilderImpl> {
       Variable* var = expr->var();
       DCHECK(var->is_function());
       WasmFunctionBuilder* function = LookupOrInsertFunction(var);
-      function->SetExported();
-      function->SetName(
+      function->SetExportedWithName(

[titzer, 2016/10/11 08:08:48]

How about ExportAs()?

(we should work incrementally to make the C++ WasmModuleBuilder more directly
reflect the JS version)

[Clemens Hammacher, 2016/10/11 08:21:54]

Is SetExportedAs better?
IMHO Export() and ExportAs() sound as if it did more than just setting a flag.

[titzer, 2016/10/11 08:36:03]

Indeed, it does a memcpy of the underlying name and stores that inside, so it's
not quite a simple setter.

The JS WasmModuleBuilder is a bit nicer to use IMO, so I think we should migrate
the C++ names closer to it, rather than the other way around.

           AsmWasmBuilder::single_function_name,
           static_cast<int>(strlen(AsmWasmBuilder::single_function_name)));
     }