[wasm] Decouple function name and exported name in WasmFunctionBuilder

src/asmjs/asm-wasm-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 // Required to get M_E etc. in MSVC.
 #if defined(_WIN32)
 #define _USE_MATH_DEFINES
 #endif
@@ skipping 546 matching lines @@
         current_function_builder_->EmitWithVarInt(
             kExprGetGlobal, LookupOrInsertGlobal(var, var_type));
       } else {
         current_function_builder_->EmitGetLocal(
             LookupOrInsertLocal(var, var_type));
       }
     } else if (scope_ == kExportScope) {
       Variable* var = expr->var();
       DCHECK(var->is_function());
       WasmFunctionBuilder* function = LookupOrInsertFunction(var);
-      function->SetExported();
-      function->SetName(
+      function->SetExportedWithName(

[titzer, 2016/10/11 08:08:48]

How about ExportAs()?

(we should work incrementally to make the C++ WasmModuleBuilder more directly
reflect the JS version)

[Clemens Hammacher, 2016/10/11 08:21:54]

Is SetExportedAs better?
IMHO Export() and ExportAs() sound as if it did more than just setting a flag.

[titzer, 2016/10/11 08:36:03]

Indeed, it does a memcpy of the underlying name and stores that inside, so it's
not quite a simple setter.

The JS WasmModuleBuilder is a bit nicer to use IMO, so I think we should migrate
the C++ names closer to it, rather than the other way around.

           AsmWasmBuilder::single_function_name,
           static_cast<int>(strlen(AsmWasmBuilder::single_function_name)));
     }
   }
 
   void VisitLiteral(Literal* expr) {
     Handle<Object> value = expr->value();
     if (!(value->IsNumber() || expr->raw_value()->IsTrue() ||
           expr->raw_value()->IsFalse()) ||
         (scope_ != kFuncScope && scope_ != kInitScope)) {
@@ skipping 1308 matching lines @@
   impl.builder_->WriteTo(*buffer);
   return buffer;
 }
 
 const char* AsmWasmBuilder::foreign_init_name = "__foreign_init__";
 const char* AsmWasmBuilder::single_function_name = "__single_function__";
 
 }  // namespace wasm
 }  // namespace internal
 }  // namespace v8