base/android/linker/config.gni - Issue 2406083002: Crazylinker: remove the code to load component build library

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/android/linker/config.gni

Issue 2406083002: Crazylinker: remove the code to load component build library (Closed)

Patch Set: remove one more component code Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/config/android/config.gni")	5 import("//build/config/android/config.gni")

6 import("//build/config/compiler/compiler.gni")	6 import("//build/config/compiler/compiler.gni")

7 import("//build/config/sanitizers/sanitizers.gni")	7 import("//build/config/sanitizers/sanitizers.gni")

8	8

9 # Chromium linker crashes on component builds on Android 4.4. See b/11379966	9 # Chromium linker crashes on component builds on Android 4.4. See b/11379966

10 # Chromium linker causes instrumentation to return incorrect results.	10 # Chromium linker causes instrumentation to return incorrect results.

	11 # As component build has stopped working for a long time, some code is broken

	12 # and needs to cleanup. See crbug.com/657093.
	Torne 2016/10/26 10:27:44 nit: this comment is hard to understand; it sounds nit: this comment is hard to understand; it sounds like someone is intending to fix this at some point, whereas it's actually the opposite. Keeping the comment about it being broken on android 4.4 also makes it less clear. I'd suggest just replacing both comments with something like: # Chromium linker doesn't reliably support loading multiple libraries; disable for component builds. What do you think? michaelbai 2016/10/26 20:35:51 Done. Show quoted text On 2016/10/26 10:27:44, Torne wrote: > nit: this comment is hard to understand; it sounds like someone is intending to > fix this at some point, whereas it's actually the opposite. Keeping the comment > about it being broken on android 4.4 also makes it less clear. > > I'd suggest just replacing both comments with something like: > > # Chromium linker doesn't reliably support loading multiple libraries; disable > for component builds. > > What do you think? Done.
11 chromium_linker_supported =	13 chromium_linker_supported =

12 !is_component_build && !enable_profiling && !use_order_profiling && !is_asan	14 !is_component_build && !enable_profiling && !use_order_profiling && !is_asan

OLD	NEW

« no previous file with comments | « base/android/java/src/org/chromium/base/library_loader/Linker.java ('k') | no next file » | no next file with comments »