Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2920)

Unified Diff: base/android/linker/config.gni

Issue 2406083002: Crazylinker: remove the code to load component build library (Closed)
Patch Set: remove one more component code Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/java/src/org/chromium/base/library_loader/Linker.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/linker/config.gni
diff --git a/base/android/linker/config.gni b/base/android/linker/config.gni
index 174c1abe7ee31bfb8ecd57244ccaad1cf49c45c7..94d0b453056907cb1883dea4d8d6c35ab3758702 100644
--- a/base/android/linker/config.gni
+++ b/base/android/linker/config.gni
@@ -8,5 +8,7 @@ import("//build/config/sanitizers/sanitizers.gni")
# Chromium linker crashes on component builds on Android 4.4. See b/11379966
# Chromium linker causes instrumentation to return incorrect results.
+# As component build has stopped working for a long time, some code is broken
+# and needs to cleanup. See crbug.com/657093.
Torne 2016/10/26 10:27:44 nit: this comment is hard to understand; it sounds
michaelbai 2016/10/26 20:35:51 Done.
chromium_linker_supported =
!is_component_build && !enable_profiling && !use_order_profiling && !is_asan
« no previous file with comments | « base/android/java/src/org/chromium/base/library_loader/Linker.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698