Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1830)

Unified Diff: chrome/renderer/extensions/app_window_custom_bindings.cc

Issue 240603003: Remove ChromeV8Extension & most of ChromeV8Context (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/app_window_custom_bindings.cc
diff --git a/chrome/renderer/extensions/app_window_custom_bindings.cc b/chrome/renderer/extensions/app_window_custom_bindings.cc
index 53a0813840d10d3ff16fde35810335a40812705b..647f74dab07471aebe6b64c5e5c15cca6b462c4b 100644
--- a/chrome/renderer/extensions/app_window_custom_bindings.cc
+++ b/chrome/renderer/extensions/app_window_custom_bindings.cc
@@ -8,7 +8,6 @@
#include "base/command_line.h"
#include "chrome/common/chrome_switches.h"
-#include "chrome/renderer/extensions/chrome_v8_context.h"
#include "chrome/renderer/extensions/dispatcher.h"
#include "content/public/renderer/render_thread.h"
#include "content/public/renderer/render_view.h"
@@ -17,6 +16,8 @@
#include "content/public/renderer/v8_value_converter.h"
#include "extensions/common/extension_messages.h"
#include "extensions/renderer/scoped_persistent.h"
+#include "extensions/renderer/script_context.h"
+#include "extensions/renderer/script_context_set.h"
#include "grit/renderer_resources.h"
#include "third_party/WebKit/public/web/WebFrame.h"
#include "third_party/WebKit/public/web/WebView.h"
@@ -27,10 +28,9 @@ namespace extensions {
class DidCreateDocumentElementObserver : public content::RenderViewObserver {
public:
- DidCreateDocumentElementObserver(
- content::RenderView* view, Dispatcher* dispatcher)
- : content::RenderViewObserver(view), dispatcher_(dispatcher) {
- }
+ DidCreateDocumentElementObserver(content::RenderView* view,
+ Dispatcher* dispatcher)
+ : content::RenderViewObserver(view), dispatcher_(dispatcher) {}
virtual void DidCreateDocumentElement(blink::WebLocalFrame* frame) OVERRIDE {
DCHECK(frame);
@@ -39,14 +39,14 @@ class DidCreateDocumentElementObserver : public content::RenderViewObserver {
if (frame->parent())
return;
v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
- ChromeV8Context* v8_context =
- dispatcher_->v8_context_set().GetByV8Context(
+ ScriptContext* script_context =
+ dispatcher_->script_context_set().GetByV8Context(
frame->mainWorldScriptContext());
- if (!v8_context)
+ if (!script_context)
return;
- v8::Context::Scope context_scope(v8_context->v8_context());
- v8_context->module_system()->CallModuleMethod(
+ v8::Context::Scope context_scope(script_context->v8_context());
+ script_context->module_system()->CallModuleMethod(
"injectAppTitlebar", "didCreateDocumentElement");
}
@@ -54,9 +54,9 @@ class DidCreateDocumentElementObserver : public content::RenderViewObserver {
Dispatcher* dispatcher_;
};
-AppWindowCustomBindings::AppWindowCustomBindings(
- Dispatcher* dispatcher,
- ChromeV8Context* context) : ChromeV8Extension(dispatcher, context) {
+AppWindowCustomBindings::AppWindowCustomBindings(Dispatcher* dispatcher,
+ ScriptContext* context)
+ : ObjectBackedNativeHandler(context), dispatcher_(dispatcher) {
RouteFunction("GetView",
base::Bind(&AppWindowCustomBindings::GetView,
base::Unretained(this)));
@@ -91,13 +91,13 @@ void AppWindowCustomBindings::GetView(
return;
if (inject_titlebar)
- new DidCreateDocumentElementObserver(view, dispatcher());
+ new DidCreateDocumentElementObserver(view, dispatcher_);
// TODO(jeremya): it doesn't really make sense to set the opener here, but we
// need to make sure the security origin is set up before returning the DOM
// reference. A better way to do this would be to have the browser pass the
// opener through so opener_id is set in RenderViewImpl's constructor.
- content::RenderView* render_view = GetRenderView();
+ content::RenderView* render_view = context()->GetRenderView();
if (!render_view)
return;
blink::WebFrame* opener = render_view->GetWebView()->mainFrame();

Powered by Google App Engine
This is Rietveld 408576698