Remove ChromeV8Extension & most of ChromeV8Context

chrome/renderer/extensions/app_bindings.cc

Index: chrome/renderer/extensions/app_bindings.cc
diff --git a/chrome/renderer/extensions/app_bindings.cc b/chrome/renderer/extensions/app_bindings.cc
index e25b81b92d64ce4868c6fca7b8be63bbb33d7bd3..6ec369c9bdd7ccc71a086bb6b5e8bece675d350d 100644
--- a/chrome/renderer/extensions/app_bindings.cc
+++ b/chrome/renderer/extensions/app_bindings.cc
@@ -11,7 +11,6 @@
 #include "base/values.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension_constants.h"
-#include "chrome/renderer/extensions/chrome_v8_context.h"
 #include "chrome/renderer/extensions/dispatcher.h"
 #include "chrome/renderer/extensions/extension_helper.h"
 #include "content/public/renderer/render_view.h"
@@ -20,7 +19,7 @@
 #include "extensions/common/extension_set.h"
 #include "extensions/common/manifest.h"
 #include "extensions/renderer/console.h"
-#include "grit/renderer_resources.h"
+#include "extensions/renderer/script_context.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "v8/include/v8.h"
@@ -58,9 +57,10 @@ const char* kInvalidCallbackIdError = "Invalid callbackId";
 
 }  // namespace
 
-AppBindings::AppBindings(Dispatcher* dispatcher, ChromeV8Context* context)
-    : ChromeV8Extension(dispatcher, context),
-      ChromeV8ExtensionHandler(context) {
+AppBindings::AppBindings(Dispatcher* dispatcher, ScriptContext* context)
+    : ObjectBackedNativeHandler(context),
+      ChromeV8ExtensionHandler(context),

[not at google - send to devlin, 2014/04/17 15:11:10]

ChromeV8ExtensionHandle is pretty cool actually. It wraps classes to make them
able to send and receive IPCs in a more sugary way. Several other classes (like
RequestSender) go through the Dispatcher which is silly, they should just listen
to the IPCs themselves.

It's also not cool because it doesn't add much value, really, and violates the
C++ multi-inheritance style guide besides.

So -- just putting this on your roadmap. We should delete
ChromeV8ExtensionHander and if it's actually valuable enough to maintain some
sort of sugar around handling IPCs then implement it using composition not
inheritance.

[Ken Rockot(use gerrit already), 2014/04/17 16:17:15]

Great, I think we're on the same page here.

[koz (OOO until 15th September), 2014/04/22 00:13:38]

Totally. De-centralising communication with the browser will also help us get
ready for Mojo, where we'd have multiple connections to the browser.

+      dispatcher_(dispatcher) {
   RouteFunction("GetIsInstalled",
       base::Bind(&AppBindings::GetIsInstalled, base::Unretained(this)));
   RouteFunction("GetDetails",