Remove ChromeV8Extension & most of ChromeV8Context

chrome/renderer/extensions/app_bindings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/app_bindings.h"
 
 #include "base/command_line.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension_constants.h"
-#include "chrome/renderer/extensions/chrome_v8_context.h"
 #include "chrome/renderer/extensions/dispatcher.h"
 #include "chrome/renderer/extensions/extension_helper.h"
 #include "content/public/renderer/render_view.h"
 #include "content/public/renderer/v8_value_converter.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/extension_set.h"
 #include "extensions/common/manifest.h"
 #include "extensions/renderer/console.h"
-#include "grit/renderer_resources.h"
+#include "extensions/renderer/script_context.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "v8/include/v8.h"
 
 using blink::WebFrame;
 using blink::WebLocalFrame;
 using content::V8ValueConverter;
 
 namespace extensions {
 
@@ skipping 17 matching lines @@
     return false;
   }
 
   return true;
 }
 
 const char* kInvalidCallbackIdError = "Invalid callbackId";
 
 }  // namespace
 
-AppBindings::AppBindings(Dispatcher* dispatcher, ChromeV8Context* context)
-    : ChromeV8Extension(dispatcher, context),
-      ChromeV8ExtensionHandler(context) {
+AppBindings::AppBindings(Dispatcher* dispatcher, ScriptContext* context)
+    : ObjectBackedNativeHandler(context),
+      ChromeV8ExtensionHandler(context),

[not at google - send to devlin, 2014/04/17 15:11:10]

ChromeV8ExtensionHandle is pretty cool actually. It wraps classes to make them
able to send and receive IPCs in a more sugary way. Several other classes (like
RequestSender) go through the Dispatcher which is silly, they should just listen
to the IPCs themselves.

It's also not cool because it doesn't add much value, really, and violates the
C++ multi-inheritance style guide besides.

So -- just putting this on your roadmap. We should delete
ChromeV8ExtensionHander and if it's actually valuable enough to maintain some
sort of sugar around handling IPCs then implement it using composition not
inheritance.

[Ken Rockot(use gerrit already), 2014/04/17 16:17:15]

Great, I think we're on the same page here.

[koz (OOO until 15th September), 2014/04/22 00:13:38]

Totally. De-centralising communication with the browser will also help us get
ready for Mojo, where we'd have multiple connections to the browser.

+      dispatcher_(dispatcher) {
   RouteFunction("GetIsInstalled",
       base::Bind(&AppBindings::GetIsInstalled, base::Unretained(this)));
   RouteFunction("GetDetails",
       base::Bind(&AppBindings::GetDetails, base::Unretained(this)));
   RouteFunction("GetDetailsForFrame",
       base::Bind(&AppBindings::GetDetailsForFrame, base::Unretained(this)));
   RouteFunction("GetInstallState",
       base::Bind(&AppBindings::GetInstallState, base::Unretained(this)));
   RouteFunction("GetRunningState",
       base::Bind(&AppBindings::GetRunningState, base::Unretained(this)));
@@ skipping 145 matching lines @@
   v8::Context::Scope context_scope(context()->v8_context());
   v8::Handle<v8::Value> argv[] = {
     v8::String::NewFromUtf8(isolate, state.c_str()),
     v8::Integer::New(isolate, callback_id)
   };
   context()->module_system()->CallModuleMethod(
       "app", "onInstallStateResponse", arraysize(argv), argv);
 }
 
 }  // namespace extensions