Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 2405993002: MD History: Use iron-a11y-announcer to announce search result messages (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

MD History: Use iron-a11y-announcer to announce search result messages The existing method we were using, `announceAccessibleMethod`, did not correctly announce messages on Canary, possibly due to timing issues. iron-a11y-announcer appears to be more robust for making sure messages are actually announced, since they do not immediately disappear from the DOM tree. BUG=606527, 653764 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2399213004 Cr-Commit-Position: refs/heads/master@{#423949} (cherry picked from commit 2a2797cc88833b227a24dfd476cb9ce125b07004) Committed: https://chromium.googlesource.com/chromium/src/+/44445bebac9e04a16653f5038f338d0ef2e6c5c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
tsergeant
Committed patchset #1 (id:1) manually as 44445bebac9e04a16653f5038f338d0ef2e6c5c2.
4 years, 2 months ago (2016-10-10 21:40:36 UTC) #2
Dan Beam
4 years, 2 months ago (2016-10-11 00:21:05 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698