Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2399213004: MD History: Use iron-a11y-announcer to announce search result messages (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Use iron-a11y-announcer to announce search result messages The existing method we were using, `announceAccessibleMethod`, did not correctly announce messages on Canary, possibly due to timing issues. iron-a11y-announcer appears to be more robust for making sure messages are actually announced, since they do not immediately disappear from the DOM tree. BUG=606527, 653764 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2a2797cc88833b227a24dfd476cb9ce125b07004 Cr-Commit-Position: refs/heads/master@{#423949}

Patch Set 1 #

Patch Set 2 : Closure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/list_container.js View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
tsergeant
michaelpg@, can you please take a look? All of the other MD History folks are ...
4 years, 2 months ago (2016-10-07 03:33:07 UTC) #8
Dan Beam
lgtm
4 years, 2 months ago (2016-10-07 20:07:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399213004/20001
4 years, 2 months ago (2016-10-07 20:08:35 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 20:14:27 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 20:16:16 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a2797cc88833b227a24dfd476cb9ce125b07004
Cr-Commit-Position: refs/heads/master@{#423949}

Powered by Google App Engine
This is Rietveld 408576698