Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3911)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

Issue 2405983002: Catch TransactionTooLargeException in another case. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
index 77a394657b9d6cc9e8ba77d0501ef19e20f98eac..50327ed2e9499075f44e0f01e24923901c9b1ee1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
@@ -305,7 +305,14 @@ public class ExternalNavigationHandler {
selector.setComponent(null);
}
- List<ResolveInfo> resolvingInfos = mDelegate.queryIntentActivities(intent);
+ List<ResolveInfo> resolvingInfos = null;
+ try {
+ resolvingInfos = mDelegate.queryIntentActivities(intent);
Maria 2016/10/10 21:31:36 I think we should do this try / catch in ExternalN
Ted C 2016/10/10 21:43:52 I was thinking that it was weird to introduce null
+ } catch (RuntimeException ex) {
+ IntentUtils.logTransactionTooLargeOrRethrow(ex, intent);
+ return OverrideUrlLoadingResult.NO_OVERRIDE;
+ }
+
boolean canResolveActivity = resolvingInfos.size() > 0;
// check whether the intent can be resolved. If not, we will see
// whether we can download it from the Market.

Powered by Google App Engine
This is Rietveld 408576698