Catch TransactionTooLargeException in another case.

chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.externalnav;
 
 import android.content.ActivityNotFoundException;
 import android.content.ComponentName;
 import android.content.Intent;
 import android.content.pm.ResolveInfo;
@@ skipping 287 matching lines @@
         // Sanitize the Intent, ensuring web pages can not bypass browser
         // security (only access to BROWSABLE activities).
         intent.addCategory(Intent.CATEGORY_BROWSABLE);
         intent.setComponent(null);
         Intent selector = intent.getSelector();
         if (selector != null) {
             selector.addCategory(Intent.CATEGORY_BROWSABLE);
             selector.setComponent(null);
         }
 
-        List<ResolveInfo> resolvingInfos = mDelegate.queryIntentActivities(intent);
+        List<ResolveInfo> resolvingInfos = null;
+        try {
+            resolvingInfos = mDelegate.queryIntentActivities(intent);

[Maria, 2016/10/10 21:31:36]

I think we should do this try / catch in
ExternalNavigationDelegateImpl.queryIntentActivities and return null -- then
exit on a null check here. This is more consistent with how we're handling other
cases in this class.

[Ted C, 2016/10/10 21:43:52]

I was thinking that it was weird to introduce null when that isn't a valid
response from Android, but I see we already do that for resolveActivity, so I
agree this is better to do in terms of consistency.

+        } catch (RuntimeException ex) {
+            IntentUtils.logTransactionTooLargeOrRethrow(ex, intent);
+            return OverrideUrlLoadingResult.NO_OVERRIDE;
+        }
+
         boolean canResolveActivity = resolvingInfos.size() > 0;
         // check whether the intent can be resolved. If not, we will see
         // whether we can download it from the Market.
         if (!canResolveActivity) {
             if (hasBrowserFallbackUrl) {
                 return clobberCurrentTabWithFallbackUrl(browserFallbackUrl, params);
             }
 
             String packagename = intent.getPackage();
             if (packagename != null) {
@@ skipping 233 matching lines @@
         if (defaultSmsPackageName == null) return null;
         // Makes sure that the default SMS app actually resolves the intent.
         for (ResolveInfo resolveInfo : resolvingComponentNames) {
             if (defaultSmsPackageName.equals(resolveInfo.activityInfo.packageName)) {
                 return defaultSmsPackageName;
             }
         }
         return null;
     }
 }