Catch TransactionTooLargeException in another case.

Catch TransactionTooLargeException in another case.

Prevent crashing the browser if dealing with long URLs when
dealing with android apis.

BUG=b/31814025

Committed: https://crrev.com/5ea9a2ee9b43ef2c898b3364ad273e6f6201dc3e
Cr-Commit-Position: refs/heads/master@{#424286}

[Ted C, 2016-10-10 21:24:54]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mariakhomenko@chromium.org

[Ted C, 2016-10-10 21:24:55]

PTAL

[Maria, 2016-10-10 21:31:36]

https://codereview.chromium.org/2405983002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/2405983002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:310:
resolvingInfos = mDelegate.queryIntentActivities(intent);
I think we should do this try / catch in
ExternalNavigationDelegateImpl.queryIntentActivities and return null -- then
exit on a null check here. This is more consistent with how we're handling other
cases in this class.

[Ted C, 2016-10-10 21:43:52]

Updated

https://codereview.chromium.org/2405983002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/2405983002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:310:
resolvingInfos = mDelegate.queryIntentActivities(intent);
On 2016/10/10 21:31:36, Maria wrote:
> I think we should do this try / catch in
> ExternalNavigationDelegateImpl.queryIntentActivities and return null -- then
> exit on a null check here. This is more consistent with how we're handling
other
> cases in this class.

I was thinking that it was weird to introduce null when that isn't a valid
response from Android, but I see we already do that for resolveActivity, so I
agree this is better to do in terms of consistency.

[Maria, 2016-10-10 22:56:56]

lgtm

https://codereview.chromium.org/2405983002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/2405983002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:136:
if (container == null) return false;
I would move this check above the hash set allocation

[Ted C, 2016-10-10 23:05:45]

https://codereview.chromium.org/2405983002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/2405983002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:136:
if (container == null) return false;
On 2016/10/10 22:56:56, Maria wrote:
> I would move this check above the hash set allocation

Done.

[Ted C, 2016-10-10 23:05:48]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2016-10-10 23:05:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2405983002/#ps40001
(title: "Address Maria's comment")

[commit-bot: I haz the power, 2016-10-10 23:06:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 23:35:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-10 23:39:18]

Description was changed from

==========
Catch TransactionTooLargeException in another case.

Prevent crashing the browser if dealing with long URLs when
dealing with android apis.

BUG=b/31814025
==========

to

==========
Catch TransactionTooLargeException in another case.

Prevent crashing the browser if dealing with long URLs when
dealing with android apis.

BUG=b/31814025

Committed: https://crrev.com/5ea9a2ee9b43ef2c898b3364ad273e6f6201dc3e
Cr-Commit-Position: refs/heads/master@{#424286}
==========

[commit-bot: I haz the power, 2016-10-10 23:39:19]

Patchset 3 (id:??) landed as
https://crrev.com/5ea9a2ee9b43ef2c898b3364ad273e6f6201dc3e
Cr-Commit-Position: refs/heads/master@{#424286}