[MD settings] inform users that the spelling service sends data to google

chrome/browser/resources/settings/privacy_page/privacy_page.html

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 717ff905cf2fc670835da652e19fa764b47eb018..cb8765232b3b3e5c17067f582db5b80032f99d2e 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -81,10 +81,6 @@
               label="$i18n{safeBrowsingEnableProtection}">
           </settings-checkbox>
 <if expr="_google_chrome">
-          <settings-checkbox
-              pref="{{prefs.spellcheck.use_spelling_service}}"
-              label="$i18n{spellingPref}">
-          </settings-checkbox>
 <if expr="chromeos">
           <settings-checkbox
               pref="{{prefs.cros.metrics.reportingEnabled}}"
@@ -123,6 +119,17 @@
           </settings-checkbox>
 </if>
         </div>
+<if expr="_google_chrome">
+        <div class="settings-box two-line" actionable
+            on-tap="onUseSpellingServiceTap_">

[hcarmona, 2016/10/08 01:06:59]

This seems odd to me. Do we have other places where clicking the row
changes the toggle?

[dschuyler, 2016/10/08 01:36:08]

Alan had requested that clicking anywhere in the row to take the action
on that row (if the row has one main action, I believe). While I don't
have another example handy, afaik this is the desired behavior.

[hcarmona, 2016/10/10 14:09:29]

OK, sounds good.

+          <div class="start">
+            $i18n{spellingPref}
+            <div class="secondary">$i18n{spellingDescription}</div>
+          </div>
+          <paper-toggle-button id="spellingServiceToggleButton">

[hcarmona, 2016/10/08 01:06:59]

If it's not a requirement that the row toggle the toggle button, then
this can be simplified by binding directly to the checked attribute:
checked="{{prefs.spellcheck.use_spelling_service.value}}"

[dschuyler, 2016/10/08 01:36:08]

That would be simpler, but afaik it's desired by UX, which is like it
being required - unless it's intractable, but it seems like small
alteration (i.e. tractable).

[hcarmona, 2016/10/10 14:09:29]

Acknowledged.

+          </paper-toggle-button>
+        </div>
+</if>
 <if expr="use_nss_certs or is_win or is_macosx">
         <div id="manageCertificates" class="settings-box two-line"
             actionable on-tap="onManageCertificatesTap_">
@@ -179,7 +186,7 @@
           <all-sites selected-site="{{selectedSite}}"></all-sites>
         </settings-subpage>
       </template>
-      <template is="dom-if" route-path="/siteSettings/automaticDownloads" no-search>
+      <template is="dom-if" route-path="/siteSettings/automaticDownloads"
           no-search>
         <settings-subpage page-title="$i18n{siteSettingsAutomaticDownloads}">
           <site-settings-category
@@ -297,7 +304,8 @@
           </site-settings-category>
         </settings-subpage>
       </template>
-      <template is="dom-if" route-path="/siteSettings/unsandboxedPlugins" no-search>
+      <template is="dom-if" route-path="/siteSettings/unsandboxedPlugins"
+          no-search>
         <settings-subpage page-title="$i18n{siteSettingsUnsandboxedPlugins}">
           <site-settings-category
               selected-site="{{selectedSite}}"