Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2405583002: Use a scoped temp dir for page load metrics download test (Closed)

Created:
4 years, 2 months ago by Bryan McQuade
Modified:
4 years, 2 months ago
Reviewers:
asanka
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a scoped temp dir for page load metrics download test BUG=653982 Committed: https://crrev.com/405e0b424390e530491f050f1721cbfe8aa37697 Cr-Commit-Position: refs/heads/master@{#423962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Bryan McQuade
PTAL, thanks!
4 years, 2 months ago (2016-10-07 20:08:49 UTC) #3
asanka
lgtm
4 years, 2 months ago (2016-10-07 20:16:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2405583002/1
4 years, 2 months ago (2016-10-07 20:58:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 21:04:36 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 21:07:36 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/405e0b424390e530491f050f1721cbfe8aa37697
Cr-Commit-Position: refs/heads/master@{#423962}

Powered by Google App Engine
This is Rietveld 408576698