Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2405583002: Use a scoped temp dir for page load metrics download test (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/scoped_temp_dir.h"
5 #include "base/macros.h" 6 #include "base/macros.h"
6 #include "base/test/histogram_tester.h" 7 #include "base/test/histogram_tester.h"
7 #include "base/time/time.h" 8 #include "base/time/time.h"
8 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h" 9 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
9 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h" 10 #include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_ob server.h"
10 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 11 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
11 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h" 12 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"
12 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h" 13 #include "chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load _metrics_observer.h"
13 #include "chrome/browser/prerender/prerender_histograms.h" 14 #include "chrome/browser/prerender/prerender_histograms.h"
14 #include "chrome/browser/prerender/prerender_origin.h" 15 #include "chrome/browser/prerender/prerender_origin.h"
15 #include "chrome/browser/profiles/profile.h" 16 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
17 #include "chrome/browser/ui/browser_navigator_params.h" 18 #include "chrome/browser/ui/browser_navigator_params.h"
18 #include "chrome/browser/ui/tabs/tab_strip_model.h" 19 #include "chrome/browser/ui/tabs/tab_strip_model.h"
20 #include "chrome/common/pref_names.h"
19 #include "chrome/common/url_constants.h" 21 #include "chrome/common/url_constants.h"
20 #include "chrome/test/base/in_process_browser_test.h" 22 #include "chrome/test/base/in_process_browser_test.h"
21 #include "chrome/test/base/ui_test_utils.h" 23 #include "chrome/test/base/ui_test_utils.h"
24 #include "components/prefs/pref_service.h"
22 #include "content/public/browser/browser_thread.h" 25 #include "content/public/browser/browser_thread.h"
23 #include "content/public/test/browser_test_utils.h" 26 #include "content/public/test/browser_test_utils.h"
24 #include "content/public/test/download_test_observer.h" 27 #include "content/public/test/download_test_observer.h"
25 #include "net/http/failing_http_transaction_factory.h" 28 #include "net/http/failing_http_transaction_factory.h"
26 #include "net/http/http_cache.h" 29 #include "net/http/http_cache.h"
27 #include "net/test/embedded_test_server/embedded_test_server.h" 30 #include "net/test/embedded_test_server/embedded_test_server.h"
28 #include "net/test/url_request/url_request_failed_job.h" 31 #include "net/test/url_request/url_request_failed_job.h"
29 #include "net/url_request/url_request_context.h" 32 #include "net/url_request/url_request_context.h"
30 #include "net/url_request/url_request_context_getter.h" 33 #include "net/url_request/url_request_context_getter.h"
31 34
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 169
167 ui_test_utils::NavigateToURL(browser(), 170 ui_test_utils::NavigateToURL(browser(),
168 embedded_test_server()->GetURL("/page204.html")); 171 embedded_test_server()->GetURL("/page204.html"));
169 NavigateToUntrackedUrl(); 172 NavigateToUntrackedUrl();
170 EXPECT_TRUE(NoPageLoadMetricsRecorded()); 173 EXPECT_TRUE(NoPageLoadMetricsRecorded());
171 } 174 }
172 175
173 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, IgnoreDownloads) { 176 IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, IgnoreDownloads) {
174 ASSERT_TRUE(embedded_test_server()->Start()); 177 ASSERT_TRUE(embedded_test_server()->Start());
175 178
179 base::ScopedTempDir downloads_directory;
180 ASSERT_TRUE(downloads_directory.CreateUniqueTempDir());
181 browser()->profile()->GetPrefs()->SetFilePath(
182 prefs::kDownloadDefaultDirectory, downloads_directory.GetPath());
176 content::DownloadTestObserverTerminal downloads_observer( 183 content::DownloadTestObserverTerminal downloads_observer(
177 content::BrowserContext::GetDownloadManager(browser()->profile()), 184 content::BrowserContext::GetDownloadManager(browser()->profile()),
178 1, // == wait_count (only waiting for "download-test3.gif"). 185 1, // == wait_count (only waiting for "download-test3.gif").
179 content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL); 186 content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
180 187
181 ui_test_utils::NavigateToURL( 188 ui_test_utils::NavigateToURL(
182 browser(), embedded_test_server()->GetURL("/download-test3.gif")); 189 browser(), embedded_test_server()->GetURL("/download-test3.gif"));
183 downloads_observer.WaitForFinished(); 190 downloads_observer.WaitForFinished();
184 191
185 NavigateToUntrackedUrl(); 192 NavigateToUntrackedUrl();
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 529
523 histogram_tester_.ExpectTotalCount( 530 histogram_tester_.ExpectTotalCount(
524 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName( 531 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(
525 prerender::ORIGIN_NONE, false, true, base::TimeDelta()), 532 prerender::ORIGIN_NONE, false, true, base::TimeDelta()),
526 1); 533 1);
527 histogram_tester_.ExpectTotalCount( 534 histogram_tester_.ExpectTotalCount(
528 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName( 535 prerender::PrerenderHistograms::GetFirstContentfulPaintHistogramName(
529 prerender::ORIGIN_NONE, false, false, base::TimeDelta()), 536 prerender::ORIGIN_NONE, false, false, base::TimeDelta()),
530 0); 537 0);
531 } 538 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698