Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2405513002: GN: Disable clang for simulators hosted on ia32 (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Disable clang for simulators hosted on ia32 Also silence a warning in tcmalloc. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/81ad8d5655095af4cc66d577804a42335208df90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/tcmalloc/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gn.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 2 months ago (2016-10-07 16:45:41 UTC) #2
Cutch
lgtm
4 years, 2 months ago (2016-10-07 16:51:48 UTC) #3
zra
4 years, 2 months ago (2016-10-07 16:56:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81ad8d5655095af4cc66d577804a42335208df90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698