Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn.py

Issue 2405513002: GN: Disable clang for simulators hosted on ia32 (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/tcmalloc/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn.py
diff --git a/tools/gn.py b/tools/gn.py
index 814441d382c331436b383f32d32196af1c8dd8b2..08d8ab7d91ce0ae2c6d4ceda27cac750f6cb29a5 100755
--- a/tools/gn.py
+++ b/tools/gn.py
@@ -106,7 +106,8 @@ def to_gn_args(args, mode, arch, target_os):
# don't use clang in that configuration.
has_clang = (host_os != 'win'
and args.os not in ['android']
- and not (gn_args['target_os'] == 'linux' and arch == 'ia32')
+ and not (gn_args['target_os'] == 'linux' and
+ gn_args['host_cpu'] == 'x86')
and not gn_args['target_cpu'].startswith('arm')
and not gn_args['target_cpu'].startswith('mips'))
gn_args['is_clang'] = args.clang and has_clang
« no previous file with comments | « third_party/tcmalloc/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698