[Video Capture Service] Move Mojo structs and enums to media/capture/mojo

media/mojo/interfaces/media_types_typemap_traits.h

Index: media/mojo/interfaces/media_types_typemap_traits.h
diff --git a/media/mojo/interfaces/media_types_typemap_traits.h b/media/mojo/interfaces/media_types_typemap_traits.h
new file mode 100644
index 0000000000000000000000000000000000000000..27c06aee40602dcd016c4aeb2cb24ea5b843cfa3
--- /dev/null
+++ b/media/mojo/interfaces/media_types_typemap_traits.h
@@ -0,0 +1,90 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_MOJO_INTERFACES_MEDIA_TYPES_TYPEMAP_TRAITS_H_
+#define MEDIA_MOJO_INTERFACES_MEDIA_TYPES_TYPEMAP_TRAITS_H_
+
+#include "media/base/video_capture_types.h"
+#include "media/mojo/interfaces/media_types.mojom.h"
+#include "mojo/common/common_custom_types_struct_traits.h"
+
+namespace mojo {
+
+template <>
+struct EnumTraits<media::mojom::VideoPixelStorage, media::VideoPixelStorage> {
+  static media::mojom::VideoPixelStorage ToMojom(
+      media::VideoPixelStorage video_pixel_storage);
+
+  static bool FromMojom(media::mojom::VideoPixelStorage input,
+                        media::VideoPixelStorage* out);
+};
+
+template <>
+struct EnumTraits<media::mojom::ResolutionChangePolicy,
+                  media::ResolutionChangePolicy> {
+  static media::mojom::ResolutionChangePolicy ToMojom(
+      media::ResolutionChangePolicy policy);
+
+  static bool FromMojom(media::mojom::ResolutionChangePolicy input,
+                        media::ResolutionChangePolicy* out);
+};
+
+template <>
+struct EnumTraits<media::mojom::PowerLineFrequency, media::PowerLineFrequency> {
+  static media::mojom::PowerLineFrequency ToMojom(
+      media::PowerLineFrequency frequency);
+
+  static bool FromMojom(media::mojom::PowerLineFrequency input,
+                        media::PowerLineFrequency* out);
+};
+
+template <>
+struct StructTraits<media::mojom::VideoCaptureFormatDataView,
+                    media::VideoCaptureFormat> {
+  static const gfx::Size& frame_size(const media::VideoCaptureFormat& format) {
+    return format.frame_size;
+  }
+
+  static float frame_rate(const media::VideoCaptureFormat& format) {
+    return format.frame_rate;
+  }
+
+  static media::mojom::VideoFormat pixel_format(
+      const media::VideoCaptureFormat& format) {
+    return static_cast<media::mojom::VideoFormat>(format.pixel_format);
+  }
+
+  static media::mojom::VideoPixelStorage pixel_storage(
+      const media::VideoCaptureFormat& format) {
+    return static_cast<media::mojom::VideoPixelStorage>(format.pixel_storage);

[xhwang, 2016/10/12 18:22:37]

You have static_cast here, do you have static_assert or test anywhere to make
sure the two enums are synced?

[Ken Rockot(use gerrit already), 2016/10/12 18:31:18]

Actually, I'd prefer that you didn't do static casts at all here. You should
either write out a switch to translate individual values, or introduce legacy
IPC traits and declare the mojom type as [Native]  (as done here:
https://codereview.chromium.org/2386443002)

I'm going to be adding a more convenient way to typemap a native enum to a mojom
declaration (one that doesn't require classic IPC traits) but it's not ready
yet.

static casts very easily mask errors. Writing out the translation for each value
guarantees that many types of errors are caught at compile time if one of the
enums changes without the other.

[Tom Sepez, 2016/10/12 20:32:08]

What Ken said.  Typically, I'd expect to see a switch here.

[chfremer, 2016/10/26 23:07:13]

Done.

+  }
+
+  static bool Read(media::mojom::VideoCaptureFormatDataView data,
+                   media::VideoCaptureFormat* out);
+};
+
+template <>
+struct StructTraits<media::mojom::VideoCaptureParamsDataView,
+                    media::VideoCaptureParams> {
+  static media::VideoCaptureFormat requested_format(
+      const media::VideoCaptureParams& params) {
+    return params.requested_format;
+  }
+
+  static media::ResolutionChangePolicy resolution_change_policy(
+      const media::VideoCaptureParams& params) {
+    return params.resolution_change_policy;
+  }
+
+  static media::PowerLineFrequency power_line_frequency(
+      const media::VideoCaptureParams& params) {
+    return params.power_line_frequency;
+  }
+
+  static bool Read(media::mojom::VideoCaptureParamsDataView data,
+                   media::VideoCaptureParams* out);
+};
+}
+
+#endif  // MEDIA_MOJO_INTERFACES_MEDIA_TYPES_TYPEMAP_TRAITS_H_