[Video Capture Service] Move Mojo structs and enums to media/capture/mojo

media/mojo/interfaces/media_types.typemap

Index: media/mojo/interfaces/media_types.typemap
diff --git a/media/mojo/interfaces/media_types.typemap b/media/mojo/interfaces/media_types.typemap
index b6a56ecd150a152363fbaafa25e57f563a4633b2..2f554f228ca37f46a30579844be144902eb7e018 100644
--- a/media/mojo/interfaces/media_types.typemap
+++ b/media/mojo/interfaces/media_types.typemap
@@ -7,16 +7,32 @@ mojom = "//media/mojo/interfaces/media_types.mojom"
 public_headers = [
   "//media/base/buffering_state.h",
   "//media/base/subsample_entry.h",
+  "//media/base/video_capture_types.h",
 ]
 
-traits_headers = [ "//media/base/ipc/media_param_traits_macros.h" ]
+traits_headers = [
+  "//media/base/ipc/media_param_traits_macros.h",
+  "//media/mojo/interfaces/media_types_typemap_traits.h",
+]
+
+sources = [
+  "//media/mojo/interfaces/media_types_typemap_traits.cc",
+]
 
 deps = [
   "//media",
   "//media/base/ipc",
+  "//media/capture",

[xhwang, 2016/10/12 18:22:37]

drive-by comment: media/mojo shouldn't depend on media/capture. Does it make
sense to move capture related mojo interfaces to somewhere like
media/capture/interfaces?

[Ken Rockot(use gerrit already), 2016/10/12 18:31:18]

Does that mean the types being typemapped from media/capture need to move to an
acceptable public target, or does that mean that these types shouldn't be
typemapped?
It was a conscious decision to place these new interfaces alongside the video
capture service.

[xhwang, 2016/10/12 18:47:25]

I actually don't see any types in media/capture are being typemapped. Am I
missing something?

That being said, it seems to me "video_capture_types.h" and
"video_capturer_source.h" should be moved from media/base to media/capture. Then
we should have the video capture mojom types defined in media/capture as well.
Sorry, I meant these video capture mojom enum types, not the actual capture mojo
interfaces.

[chfremer, 2016/10/12 20:07:42]

I feel there is value in having the Mojo types and corresponding typemapped C++
structs/enums live in the same place. It also seems reasonable to keep the
capture-specific things separate from the other things in media.

How about I create a new CL that does the following: 
* Move "video_capture_types.h" and "video_capturer_source.h" to media/capture
* Create media/capture/mojo and move the capture-specific Mojo types and
typemaps into there.

The reason why I would like to move the Mojo equivalents of things like
VideoCaptureFormat and VideoCaptureParams out of services/video_capture is that
the Mojo API exposed by services/video_capture is different from the C++ API
exposed by the things in media/capture/video. For example, the service
guarantees that frames are delivered in I420, and therefore does not want to
expose a parameter for VideoPixelFormat.

[chfremer, 2016/10/26 23:07:13]

Done.

+  "//ui/gfx/geometry/mojo",
+  "//ui/gfx/geometry/mojo:struct_traits",
 ]
 
 type_mappings = [
   "media.mojom.BufferingState=media::BufferingState",
   "media.mojom.SubsampleEntry=media::SubsampleEntry",
+  "media.mojom.ResolutionChangePolicy=media::ResolutionChangePolicy",
+  "media.mojom.PowerLineFrequency=media::PowerLineFrequency",
+  "media.mojom.VideoCaptureFormat=media::VideoCaptureFormat",
+  "media.mojom.VideoPixelStorage=media::VideoPixelStorage",
+  "media.mojom.VideoCaptureParams=media::VideoCaptureParams",
 ]