Improvements to NoSuchMethodError.toString

Improvements to NoSuchMethodError.toString

This makes the following improvements:

* Always show the call that was made, with arguments.
* ...and show the actual arguments in more cases.
* Be less confusing in the case of a call on the null receiver.
* Be less redundant in the output.
* Report when a constructor is called with the wrong number of arguments.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/7fd9df4d91cb9d9f6f415627f4b60be60810d0a6

[Cutch, 2016-10-11 20:40:29]

Description was changed from

==========
Improvements to NoSuchMethodError.toString

This makes the following improvements:

* Always show the call that was made, with arguments.
* ...and show the actual arguments in more cases.
* Be less confusing in the case of a call on the null receiver.
* Be less redundant in the output.
* Report when a constructor is called with the wrong number of arguments.
==========

to

==========
Improvements to NoSuchMethodError.toString

This makes the following improvements:

* Always show the call that was made, with arguments.
* ...and show the actual arguments in more cases.
* Be less confusing in the case of a call on the null receiver.
* Be less redundant in the output.
* Report when a constructor is called with the wrong number of arguments.
==========

[Cutch, 2016-10-11 20:40:30]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com

[Hixie, 2016-10-11 21:49:58]

ianh@google.com changed reviewers:
- johnmccutchan@google.com

[Hixie, 2016-10-11 21:49:59]

Here'

[Hixie, 2016-10-11 21:51:24]

Sorry about that. What I meant to say was:

Here's a file that shows sample before and after messages:


simple() { }

complex(int x) { }

class A {
  A();
  A.makeSimple() { }
  A.makeComplex(int x) { }
  simple() { }
  complex(int x) { }
  test() { super.test(); }
  static bar() { }
}

main() {
  foo();
  /*
Before:
  No top-level method 'foo' declared.

  NoSuchMethodError: method not found: 'foo'
  Receiver: top-level
  Arguments: [...]

After:
  NoSuchMethodError: No top-level method 'foo' declared.
  Receiver: top-level
  Tried calling: foo()

  */

  foo("hello");
  /*
Before:
  No top-level method 'foo' declared.

  NoSuchMethodError: method not found: 'foo'
  Receiver: top-level
  Arguments: ["hello"]

After:
  NoSuchMethodError: No top-level method 'foo' declared.
  Receiver: top-level
  Tried calling: foo("hello")

  */

  null.foo();
  /*
Before:
  The null object does not have a method 'foo'.

  NoSuchMethodError: method not found: 'foo'
  Receiver: null
  Arguments: []

After:
  NoSuchMethodError: The method 'foo' was called on null.
  Receiver: null
  Tried calling: foo()

  */

  null.foo;
  /*
Before:
  The null object does not have a getter 'foo'.

  NoSuchMethodError: method not found: 'foo'
  Receiver: null
  Arguments: []

After:
  NoSuchMethodError: The getter 'foo' was called on null.
  Receiver: null
  Tried calling: foo

  */

  null.foo = 1;
  /*
Before:
  The null object does not have a setter 'foo='.

  NoSuchMethodError: method not found: 'foo='
  Receiver: null
  Arguments: [1]

After:
  NoSuchMethodError: The setter 'foo=' was called on null.
  Receiver: null
  Tried calling: foo=1

  */

  null.toString(1);
  /*
Before:
  The null object does not have a method 'toString' with matching arguments.

  NoSuchMethodError: incorrect number of arguments passed to method named
'toString'
  Receiver: null
  Tried calling: toString(1)

After:
  NoSuchMethodError: The null object does not have a method 'toString' with
matching arguments.
  Receiver: null
  Tried calling: toString(1)
  Found: toString()

  */

  simple(1);
  /*
Before:
  No top-level method 'simple' with matching arguments declared.

  NoSuchMethodError: incorrect number of arguments passed to method named
'simple'
  Receiver: top-level
  Tried calling: simple(1)
  Found: simple()

After:
  NoSuchMethodError: No top-level method 'simple' with matching arguments
declared.
  Receiver: top-level
  Tried calling: simple(1)
  Found: simple()

  */

  complex();
  /*
Before:
  No top-level method 'complex' with matching arguments declared.

  NoSuchMethodError: incorrect number of arguments passed to method named
'complex'
  Receiver: top-level
  Tried calling: complex(...)
  Found: complex(int)

After:
  NoSuchMethodError: No top-level method 'complex' with matching arguments
declared.
  Receiver: top-level
  Tried calling: complex()
  Found: complex(int)

  */

  complex(arg: 1);
  /*
Before:
  No top-level method 'complex' with matching arguments declared.

  NoSuchMethodError: incorrect number of arguments passed to method named
'complex'
  Receiver: top-level
  Tried calling: complex(arg: 1)
  Found: complex(int)

After:
  NoSuchMethodError: No top-level method 'complex' with matching arguments
declared.
  Receiver: top-level
  Tried calling: complex(arg: 1)
  Found: complex(int)

  */

  A.foo();
  /*
Before:
  No static method 'foo' declared in class 'A'.

  NoSuchMethodError: method not found: 'foo'
  Receiver: Type: class 'A'
  Arguments: [...]

After:
  NoSuchMethodError: No static method 'foo' declared in class 'A'.
  Receiver: Type: class 'A'
  Tried calling: foo()

  */

  A.bar("hello");
  /*
Before:
  No static method 'bar' declared in class 'A'.

  NoSuchMethodError: incorrect number of arguments passed to method named 'bar'
  Receiver: Type: class 'A'
  Tried calling: bar("hello")
  Found: bar()

After:
  NoSuchMethodError: No static method 'bar' with matching arguments declared in
class 'A'.
  Receiver: Type: class 'A'
  Tried calling: bar("hello")
  Found: bar()

  */

  new A.foo();
  /*
Before:
  No constructor 'A.foo' declared in class 'A'.

  NoSuchMethodError: method not found: 'A.foo'
  Receiver: Type: class 'A'
  Arguments: [...]

After:
  NoSuchMethodError: No constructor 'A.foo' declared in class 'A'.
  Receiver: Type: class 'A'
  Tried calling: new A.foo()

  */

  new A.makeSimple(1);
  /*
Before:
  No constructor 'A.makeSimple' with matching arguments declared in class 'A'.

  NoSuchMethodError: incorrect number of arguments passed to method named
'A.makeSimple'
  Receiver: Type: class 'A'
  Tried calling: A.makeSimple(1)
  Found: A.makeSimple()

After:
  NoSuchMethodError: No constructor 'A.makeSimple' with matching arguments
declared in class 'A'.
  Receiver: Type: class 'A'
  Tried calling: new A.makeSimple(1)
  Found: new A.makeSimple()

  */

  new A.makeComplex();
  /*
Before:
  No constructor 'A.makeComplex' with matching arguments declared in class 'A'.

  NoSuchMethodError: incorrect number of arguments passed to method named
'A.makeComplex'
  Receiver: Type: class 'A'
  Tried calling: A.makeComplex(...)
  Found: A.makeComplex(int)

After:
  NoSuchMethodError: No constructor 'A.makeComplex' with matching arguments
declared in class 'A'.
  Receiver: Type: class 'A'
  Tried calling: new A.makeComplex()
  Found: new A.makeComplex(int)

  */

  new A().foo();
  /*
Before:
  Class 'A' has no instance method 'foo'.

  NoSuchMethodError: method not found: 'foo'
  Receiver: Instance of 'A'
  Arguments: []

After:
  NoSuchMethodError: Class 'A' has no instance method 'foo'.
  Receiver: Instance of 'A'
  Tried calling: foo()

  */

  new A().simple(1);
  /*
Before:
  Class 'A' has no instance method 'simple' with matching arguments.

  NoSuchMethodError: incorrect number of arguments passed to method named
'simple'
  Receiver: Instance of 'A'
  Tried calling: simple(1)
  Found: simple()

After:
  NoSuchMethodError: Class 'A' has no instance method 'simple' with matching
arguments.
  Receiver: Instance of 'A'
  Tried calling: simple(1)
  Found: simple()

  */

  new A().complex();
  /*
Before:
  Class 'A' has no instance method 'complex' with matching arguments.

  NoSuchMethodError: incorrect number of arguments passed to method named
'complex'
  Receiver: Instance of 'A'
  Tried calling: complex()
  Found: complex(x)

After:
  NoSuchMethodError: Class 'A' has no instance method 'complex' with matching
arguments.
  Receiver: Instance of 'A'
  Tried calling: complex()
  Found: complex(x)

  */

  new A().test();
  /*
Before:
  Super class of class 'A' has no instance method 'test'.

  NoSuchMethodError: method not found: 'test'
  Receiver: Instance of 'A'
  Arguments: []

After:
  NoSuchMethodError: Super class of class 'A' has no instance method 'test'.
  Receiver: Instance of 'A'
  Tried calling: super.test()

  */
}

[Cutch, 2016-10-11 22:34:58]

johnmccutchan@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com

[Cutch, 2016-10-11 22:34:59]

LGTMwC

+rmacnak

https://codereview.chromium.org/2405353002/diff/20001/runtime/lib/errors_patc...
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/2405353002/diff/20001/runtime/lib/errors_patc...
runtime/lib/errors_patch.dart:250: argumentCount = 0;
redundant

[rmacnak, 2016-10-11 22:55:02]

lgtm

https://codereview.chromium.org/2405353002/diff/20001/runtime/lib/errors_patc...
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/2405353002/diff/20001/runtime/lib/errors_patc...
runtime/lib/errors_patch.dart:326: } else if (_receiver == null) {
Redundant with else case.

[Cutch, 2016-10-12 16:52:57]

Description was changed from

==========
Improvements to NoSuchMethodError.toString

This makes the following improvements:

* Always show the call that was made, with arguments.
* ...and show the actual arguments in more cases.
* Be less confusing in the case of a call on the null receiver.
* Be less redundant in the output.
* Report when a constructor is called with the wrong number of arguments.
==========

to

==========
Improvements to NoSuchMethodError.toString

This makes the following improvements:

* Always show the call that was made, with arguments.
* ...and show the actual arguments in more cases.
* Be less confusing in the case of a call on the null receiver.
* Be less redundant in the output.
* Report when a constructor is called with the wrong number of arguments.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7fd9df4d91cb9d9f6f415627f4b60be60810d0a6
==========

[Cutch, 2016-10-12 16:52:58]

Committed patchset #4 (id:60001) manually as
7fd9df4d91cb9d9f6f415627f4b60be60810d0a6 (presubmit successful).