Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: runtime/vm/isolate_reload_test.cc

Issue 2405353002: Improvements to NoSuchMethodError.toString (Closed)
Patch Set: Fix for Ryan's comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/errors_patch.dart ('k') | tests/language/vm/no_such_method_error_message_vm_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate_reload_test.cc
diff --git a/runtime/vm/isolate_reload_test.cc b/runtime/vm/isolate_reload_test.cc
index 4543baa994e5b9f7bcc806f9059bb0dfbf3955d4..e33cb97f82c14e66f9d61d8cac2398219ad35745 100644
--- a/runtime/vm/isolate_reload_test.cc
+++ b/runtime/vm/isolate_reload_test.cc
@@ -1536,7 +1536,7 @@ TEST_CASE(IsolateReload_DanglingGetter_Instance) {
TestCase::SetReloadTestScript(kReloadScript);
- EXPECT_STREQ("4 Class 'C' has no instance getter 'y'.",
+ EXPECT_STREQ("4 NoSuchMethodError: Class 'C' has no instance getter 'y'.",
SimpleInvokeStr(lib, "main"));
lib = TestCase::GetReloadErrorOrRootLibrary();
@@ -1595,8 +1595,8 @@ TEST_CASE(IsolateReload_DanglingGetter_Class) {
TestCase::SetReloadTestScript(kReloadScript);
- EXPECT_STREQ("4 No static getter 'y' declared in class 'C'.",
- SimpleInvokeStr(lib, "main"));
+ EXPECT_STREQ("4 NoSuchMethodError: No static getter 'y' declared "
+ "in class 'C'.", SimpleInvokeStr(lib, "main"));
lib = TestCase::GetReloadErrorOrRootLibrary();
EXPECT_VALID(lib);
@@ -1653,7 +1653,7 @@ TEST_CASE(IsolateReload_DanglingGetter_Library) {
TestCase::SetReloadTestScript(kScript); // Root library does not change.
- EXPECT_STREQ("4 No top-level getter 'y' declared.",
+ EXPECT_STREQ("4 NoSuchMethodError: No top-level getter 'y' declared.",
SimpleInvokeStr(lib, "main"));
lib = TestCase::GetReloadErrorOrRootLibrary();
@@ -1710,7 +1710,7 @@ TEST_CASE(IsolateReload_DanglingSetter_Instance) {
TestCase::SetReloadTestScript(kReloadScript);
- EXPECT_STREQ("null Class 'C' has no instance setter 'y='.",
+ EXPECT_STREQ("null NoSuchMethodError: Class 'C' has no instance setter 'y='.",
SimpleInvokeStr(lib, "main"));
lib = TestCase::GetReloadErrorOrRootLibrary();
@@ -1769,8 +1769,8 @@ TEST_CASE(IsolateReload_DanglingSetter_Class) {
TestCase::SetReloadTestScript(kReloadScript);
- EXPECT_STREQ("5 No static setter 'y=' declared in class 'C'.",
- SimpleInvokeStr(lib, "main"));
+ EXPECT_STREQ("5 NoSuchMethodError: No static setter 'y=' declared in "
+ "class 'C'.", SimpleInvokeStr(lib, "main"));
lib = TestCase::GetReloadErrorOrRootLibrary();
EXPECT_VALID(lib);
@@ -1827,7 +1827,7 @@ TEST_CASE(IsolateReload_DanglingSetter_Library) {
TestCase::SetReloadTestScript(kScript); // Root library does not change.
- EXPECT_STREQ("5 No top-level setter 'y=' declared.",
+ EXPECT_STREQ("5 NoSuchMethodError: No top-level setter 'y=' declared.",
SimpleInvokeStr(lib, "main"));
lib = TestCase::GetReloadErrorOrRootLibrary();
@@ -1883,8 +1883,8 @@ TEST_CASE(IsolateReload_TearOff_AddArguments) {
TestCase::SetReloadTestScript(kReloadScript);
- EXPECT_STREQ("1 Class 'C' has no instance method 'foo' with matching"
- " arguments.", SimpleInvokeStr(lib, "main"));
+ EXPECT_STREQ("1 NoSuchMethodError: Class 'C' has no instance method "
+ "'foo' with matching arguments.", SimpleInvokeStr(lib, "main"));
lib = TestCase::GetReloadErrorOrRootLibrary();
EXPECT_VALID(lib);
@@ -1937,8 +1937,8 @@ TEST_CASE(IsolateReload_TearOff_AddArguments2) {
TestCase::SetReloadTestScript(kReloadScript);
- EXPECT_STREQ("1 Closure call with mismatched arguments: function 'C.foo'",
- SimpleInvokeStr(lib, "main"));
+ EXPECT_STREQ("1 NoSuchMethodError: Closure call with mismatched arguments: "
+ "function 'C.foo'", SimpleInvokeStr(lib, "main"));
lib = TestCase::GetReloadErrorOrRootLibrary();
EXPECT_VALID(lib);
« no previous file with comments | « runtime/lib/errors_patch.dart ('k') | tests/language/vm/no_such_method_error_message_vm_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698