Add remoting::protocol::NetworkStateObserver interface.

Add remoting::protocol::NetworkStateObserver interface.

Previously WebrtcDummyVideoEncoder was using callbacks to report
network bitrate and keyframe requests. With this change the new
NetworkStateObserver interface will be used instead. This simplifies
how the notifications are passed to the frame scheduler and also allows
the frame scheduler to receive RTT estimate if it needs to use it.

Also cleaned up threading logic in WebrtcDummyVideoEncoder and
WebrtcDummyVideoEncoderFactory.

Committed: https://crrev.com/78f725b7236b2f7823ecaeacf393ff7ab984ffa4
Cr-Commit-Position: refs/heads/master@{#424595}

[Sergey Ulanov, 2016-10-11 21:42:31]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-10-11 21:58:33]

lgtm

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
File remoting/protocol/webrtc_dummy_video_encoder.cc (right):

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
remoting/protocol/webrtc_dummy_video_encoder.cc:70: network_state_observer_));
It's not clear from the context that a key frame is being requested here. Is
there a better name for the callback?

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
remoting/protocol/webrtc_dummy_video_encoder.cc:187: NOTREACHED();
I think leaving the error message is worthwhile.

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
File remoting/protocol/webrtc_dummy_video_encoder.h (right):

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
remoting/protocol/webrtc_dummy_video_encoder.h:27: // in
WebrtcDummyVideoEncoderFactory. Video frames are captured encoded outside
s/captured encoded/captured and encoded/?

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
remoting/protocol/webrtc_dummy_video_encoder.h:28: // of this dummy encoder (in
WebrtcVideoEncoded called from WebrtcVideoStream).
s/WebrtcVideoEncoded/WebrtcVideoEncoder/

[Sergey Ulanov, 2016-10-11 22:36:24]

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
File remoting/protocol/webrtc_dummy_video_encoder.cc (right):

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
remoting/protocol/webrtc_dummy_video_encoder.cc:70: network_state_observer_));
On 2016/10/11 21:58:33, Jamie wrote:
> It's not clear from the context that a key frame is being requested here. Is
> there a better name for the callback?

Added a comment here to make it clear what's going on.

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
remoting/protocol/webrtc_dummy_video_encoder.cc:187: NOTREACHED();
On 2016/10/11 21:58:33, Jamie wrote:
> I think leaving the error message is worthwhile.

Done.

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
File remoting/protocol/webrtc_dummy_video_encoder.h (right):

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
remoting/protocol/webrtc_dummy_video_encoder.h:27: // in
WebrtcDummyVideoEncoderFactory. Video frames are captured encoded outside
On 2016/10/11 21:58:33, Jamie wrote:
> s/captured encoded/captured and encoded/?

Done.

https://codereview.chromium.org/2405333002/diff/1/remoting/protocol/webrtc_du...
remoting/protocol/webrtc_dummy_video_encoder.h:28: // of this dummy encoder (in
WebrtcVideoEncoded called from WebrtcVideoStream).
On 2016/10/11 21:58:33, Jamie wrote:
> s/WebrtcVideoEncoded/WebrtcVideoEncoder/

Done.

[Sergey Ulanov, 2016-10-11 22:36:35]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2016-10-11 22:36:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2405333002/#ps20001
(title: "address feedback")

[commit-bot: I haz the power, 2016-10-11 22:37:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 23:35:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-11 23:40:21]

Description was changed from

==========
Add remoting::protocol::NetworkStateObserver interface.

Previously WebrtcDummyVideoEncoder was using callbacks to report
network bitrate and keyframe requests. With this change the new
NetworkStateObserver interface will be used instead. This simplifies
how the notifications are passed to the frame scheduler and also allows
the frame scheduler to receive RTT estimate if it needs to use it.

Also cleaned up threading logic in WebrtcDummyVideoEncoder and
WebrtcDummyVideoEncoderFactory.
==========

to

==========
Add remoting::protocol::NetworkStateObserver interface.

Previously WebrtcDummyVideoEncoder was using callbacks to report
network bitrate and keyframe requests. With this change the new
NetworkStateObserver interface will be used instead. This simplifies
how the notifications are passed to the frame scheduler and also allows
the frame scheduler to receive RTT estimate if it needs to use it.

Also cleaned up threading logic in WebrtcDummyVideoEncoder and
WebrtcDummyVideoEncoderFactory.

Committed: https://crrev.com/78f725b7236b2f7823ecaeacf393ff7ab984ffa4
Cr-Commit-Position: refs/heads/master@{#424595}
==========

[commit-bot: I haz the power, 2016-10-11 23:40:22]

Patchset 2 (id:??) landed as
https://crrev.com/78f725b7236b2f7823ecaeacf393ff7ab984ffa4
Cr-Commit-Position: refs/heads/master@{#424595}